From a015559e3e5275bfdfced0d3ae4d2d4250ca7437 Mon Sep 17 00:00:00 2001 From: Bernhard Owen Josephus Date: Fri, 5 Jan 2024 00:23:09 +0800 Subject: [PATCH 1/3] set a button role --- src/components/BaseMiniContextMenuItem.tsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/components/BaseMiniContextMenuItem.tsx b/src/components/BaseMiniContextMenuItem.tsx index 1f9a14cdfdee..dcb0ffc71627 100644 --- a/src/components/BaseMiniContextMenuItem.tsx +++ b/src/components/BaseMiniContextMenuItem.tsx @@ -10,6 +10,7 @@ import ReportActionComposeFocusManager from '@libs/ReportActionComposeFocusManag import variables from '@styles/variables'; import PressableWithoutFeedback from './Pressable/PressableWithoutFeedback'; import Tooltip from './Tooltip/PopoverAnchorTooltip'; +import CONST from '@src/CONST'; type BaseMiniContextMenuItemProps = { /** @@ -66,6 +67,7 @@ function BaseMiniContextMenuItem({tooltipText, onPress, children, isDelayButtonS event.preventDefault(); }} accessibilityLabel={tooltipText} + role={CONST.ROLE.BUTTON} style={({hovered, pressed}) => [ styles.reportActionContextMenuMiniButton, StyleUtils.getButtonBackgroundColorStyle(getButtonState(hovered, pressed, isDelayButtonStateComplete)), From ffd4db3556702a4c5875d6c15231fd3754af9e63 Mon Sep 17 00:00:00 2001 From: Bernhard Owen Josephus Date: Fri, 5 Jan 2024 00:23:25 +0800 Subject: [PATCH 2/3] set mini context menu unselectable --- src/styles/utils/index.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/styles/utils/index.ts b/src/styles/utils/index.ts index b3b4924ebb19..61549fcd2177 100644 --- a/src/styles/utils/index.ts +++ b/src/styles/utils/index.ts @@ -1345,6 +1345,7 @@ const createStyleUtils = (theme: ThemeColors, styles: ThemeStyles) => ({ ...(isReportActionItemGrouped ? positioning.tn8 : positioning.tn4), ...positioning.r4, ...styles.cursorDefault, + ...styles.userSelectNone, position: 'absolute', zIndex: 8, }), From edd2a205ea1aac9a416618f5595107727ace69e5 Mon Sep 17 00:00:00 2001 From: Bernhard Owen Josephus Date: Fri, 5 Jan 2024 00:30:53 +0800 Subject: [PATCH 3/3] prettier --- src/components/BaseMiniContextMenuItem.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/BaseMiniContextMenuItem.tsx b/src/components/BaseMiniContextMenuItem.tsx index dcb0ffc71627..7bed44cd8f13 100644 --- a/src/components/BaseMiniContextMenuItem.tsx +++ b/src/components/BaseMiniContextMenuItem.tsx @@ -8,9 +8,9 @@ import DomUtils from '@libs/DomUtils'; import getButtonState from '@libs/getButtonState'; import ReportActionComposeFocusManager from '@libs/ReportActionComposeFocusManager'; import variables from '@styles/variables'; +import CONST from '@src/CONST'; import PressableWithoutFeedback from './Pressable/PressableWithoutFeedback'; import Tooltip from './Tooltip/PopoverAnchorTooltip'; -import CONST from '@src/CONST'; type BaseMiniContextMenuItemProps = { /**