From 8213ec3a8daf04187aa4cba3dc0632c754e4774d Mon Sep 17 00:00:00 2001 From: FitseTLT Date: Thu, 2 May 2024 15:56:23 +0300 Subject: [PATCH 1/2] fixed no activity yet bug --- src/libs/OptionsListUtils.ts | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/libs/OptionsListUtils.ts b/src/libs/OptionsListUtils.ts index 431cd1a3e820..069ef6659133 100644 --- a/src/libs/OptionsListUtils.ts +++ b/src/libs/OptionsListUtils.ts @@ -526,12 +526,9 @@ function getLastActorDisplayName(lastActorDetails: Partial | nu /** * Update alternate text for the option when applicable */ -function getAlternateText( - option: ReportUtils.OptionData, - {showChatPreviewLine = false, forcePolicyNamePreview = false, lastMessageTextFromReport = ''}: PreviewConfig & {lastMessageTextFromReport?: string}, -) { +function getAlternateText(option: ReportUtils.OptionData, {showChatPreviewLine = false, forcePolicyNamePreview = false}: PreviewConfig & {lastMessageTextFromReport?: string}) { if (!!option.isThread || !!option.isMoneyRequestReport) { - return lastMessageTextFromReport.length > 0 ? option.lastMessageText : Localize.translate(preferredLocale, 'report.noActivityYet'); + return option.lastMessageText ? option.lastMessageText : Localize.translate(preferredLocale, 'report.noActivityYet'); } if (!!option.isChatRoom || !!option.isPolicyExpenseChat) { return showChatPreviewLine && !forcePolicyNamePreview && option.lastMessageText ? option.lastMessageText : option.subtitle; @@ -714,8 +711,7 @@ function createOption( result.lastMessageText = lastMessageText; // If displaying chat preview line is needed, let's overwrite the default alternate text - result.alternateText = - showPersonalDetails && personalDetail?.login ? personalDetail.login : getAlternateText(result, {showChatPreviewLine, forcePolicyNamePreview, lastMessageTextFromReport}); + result.alternateText = showPersonalDetails && personalDetail?.login ? personalDetail.login : getAlternateText(result, {showChatPreviewLine, forcePolicyNamePreview}); reportName = showPersonalDetails ? ReportUtils.getDisplayNameForParticipant(accountIDs[0]) || LocalePhoneNumber.formatPhoneNumber(personalDetail?.login ?? '') From 0037a6a2087abde6c1534869c036ddeae4e037fe Mon Sep 17 00:00:00 2001 From: FitseTLT Date: Mon, 6 May 2024 23:01:49 +0300 Subject: [PATCH 2/2] remove lastmessage from the signature --- src/libs/OptionsListUtils.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libs/OptionsListUtils.ts b/src/libs/OptionsListUtils.ts index 069ef6659133..f83c52863acb 100644 --- a/src/libs/OptionsListUtils.ts +++ b/src/libs/OptionsListUtils.ts @@ -526,7 +526,7 @@ function getLastActorDisplayName(lastActorDetails: Partial | nu /** * Update alternate text for the option when applicable */ -function getAlternateText(option: ReportUtils.OptionData, {showChatPreviewLine = false, forcePolicyNamePreview = false}: PreviewConfig & {lastMessageTextFromReport?: string}) { +function getAlternateText(option: ReportUtils.OptionData, {showChatPreviewLine = false, forcePolicyNamePreview = false}: PreviewConfig) { if (!!option.isThread || !!option.isMoneyRequestReport) { return option.lastMessageText ? option.lastMessageText : Localize.translate(preferredLocale, 'report.noActivityYet'); }