From 86909de9bb244ae1ad83e0456e481c3305fc138a Mon Sep 17 00:00:00 2001 From: Blazej Kustra Date: Mon, 28 Oct 2024 10:21:19 +0100 Subject: [PATCH 1/3] Simplify access to the debug menu on production --- src/components/TestToolsModal.tsx | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/components/TestToolsModal.tsx b/src/components/TestToolsModal.tsx index 5c330bd700e0..7ce35d951613 100644 --- a/src/components/TestToolsModal.tsx +++ b/src/components/TestToolsModal.tsx @@ -2,7 +2,6 @@ import React from 'react'; import {View} from 'react-native'; import type {OnyxEntry} from 'react-native-onyx'; import {withOnyx} from 'react-native-onyx'; -import useEnvironment from '@hooks/useEnvironment'; import useLocalize from '@hooks/useLocalize'; import useStyleUtils from '@hooks/useStyleUtils'; import useThemeStyles from '@hooks/useThemeStyles'; @@ -31,7 +30,6 @@ type TestToolsModalOnyxProps = { type TestToolsModalProps = TestToolsModalOnyxProps; function TestToolsModal({isTestToolsModalOpen = false, shouldStoreLogs = false}: TestToolsModalProps) { - const {isProduction} = useEnvironment(); const {windowWidth} = useWindowDimensions(); const StyleUtils = useStyleUtils(); const styles = useThemeStyles(); @@ -64,7 +62,7 @@ function TestToolsModal({isTestToolsModalOpen = false, shouldStoreLogs = false}: /> )} - {!isProduction && } + ); From 659908294f7b8f62f4d6d31c2878d92dec9558fc Mon Sep 17 00:00:00 2001 From: Blazej Kustra Date: Mon, 28 Oct 2024 10:41:32 +0100 Subject: [PATCH 2/3] Migrate TestToolsModal to use useOnyx --- src/components/TestToolsModal.tsx | 26 +++++--------------------- 1 file changed, 5 insertions(+), 21 deletions(-) diff --git a/src/components/TestToolsModal.tsx b/src/components/TestToolsModal.tsx index 7ce35d951613..7c2e161b2d11 100644 --- a/src/components/TestToolsModal.tsx +++ b/src/components/TestToolsModal.tsx @@ -1,7 +1,6 @@ import React from 'react'; import {View} from 'react-native'; -import type {OnyxEntry} from 'react-native-onyx'; -import {withOnyx} from 'react-native-onyx'; +import {useOnyx} from 'react-native-onyx'; import useLocalize from '@hooks/useLocalize'; import useStyleUtils from '@hooks/useStyleUtils'; import useThemeStyles from '@hooks/useThemeStyles'; @@ -19,17 +18,9 @@ import TestToolMenu from './TestToolMenu'; import TestToolRow from './TestToolRow'; import Text from './Text'; -type TestToolsModalOnyxProps = { - /** Whether the test tools modal is open */ - isTestToolsModalOpen: OnyxEntry; - - /** Whether or not logs should be stored */ - shouldStoreLogs: OnyxEntry; -}; - -type TestToolsModalProps = TestToolsModalOnyxProps; - -function TestToolsModal({isTestToolsModalOpen = false, shouldStoreLogs = false}: TestToolsModalProps) { +function TestToolsModal() { + const [isTestToolsModalOpen = false] = useOnyx(ONYXKEYS.IS_TEST_TOOLS_MODAL_OPEN); + const [shouldStoreLogs = false] = useOnyx(ONYXKEYS.SHOULD_STORE_LOGS); const {windowWidth} = useWindowDimensions(); const StyleUtils = useStyleUtils(); const styles = useThemeStyles(); @@ -70,11 +61,4 @@ function TestToolsModal({isTestToolsModalOpen = false, shouldStoreLogs = false}: TestToolsModal.displayName = 'TestToolsModal'; -export default withOnyx({ - isTestToolsModalOpen: { - key: ONYXKEYS.IS_TEST_TOOLS_MODAL_OPEN, - }, - shouldStoreLogs: { - key: ONYXKEYS.SHOULD_STORE_LOGS, - }, -})(TestToolsModal); +export default TestToolsModal; From de13f045b9e6388c279a36d9eec309f95246b8a0 Mon Sep 17 00:00:00 2001 From: Blazej Kustra Date: Mon, 28 Oct 2024 10:41:42 +0100 Subject: [PATCH 3/3] Fix a typo --- src/components/ScreenWrapper.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/ScreenWrapper.tsx b/src/components/ScreenWrapper.tsx index 4a7aab4ad299..3645b832ed43 100644 --- a/src/components/ScreenWrapper.tsx +++ b/src/components/ScreenWrapper.tsx @@ -172,7 +172,7 @@ function ScreenWrapper( }), ).current; - const keyboardDissmissPanResponder = useRef( + const keyboardDismissPanResponder = useRef( PanResponder.create({ onMoveShouldSetPanResponderCapture: (_e, gestureState) => { const isHorizontalSwipe = Math.abs(gestureState.dx) > Math.abs(gestureState.dy); @@ -265,7 +265,7 @@ function ScreenWrapper( fsClass="fs-unmask" style={[styles.flex1, paddingStyle, style]} // eslint-disable-next-line react/jsx-props-no-spreading - {...keyboardDissmissPanResponder.panHandlers} + {...keyboardDismissPanResponder.panHandlers} >