Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

home.js could use reduce to get total #32

Open
mattlub opened this issue Apr 6, 2017 · 4 comments
Open

home.js could use reduce to get total #32

mattlub opened this issue Apr 6, 2017 · 4 comments
Assignees
@philawsophizing
Labels
addressed enhancement

Comments

@mattlub
Copy link
Member

mattlub commented Apr 6, 2017

instead of a for each

https://github.com/FACN1/week7-rm-rf-mario/blob/master/src/routes/home.js#L10
@philawsophizing philawsophizing self-assigned this Apr 6, 2017
@philawsophizing
Copy link
Contributor

changed. Just better because it's more explicit?

@mattlub
Copy link
Member Author

mattlub commented Apr 6, 2017

link to pull request?

@jwld jwld mentioned this issue Apr 6, 2017
Merged
@mattlub
Copy link
Member Author

mattlub commented Apr 6, 2017

yeh, better I would say as it's cleaner

@mattlub
Copy link
Member Author

mattlub commented Apr 6, 2017

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philawsophizing philawsophizing

Labels
addressed enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattlub @philawsophizing