Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some issues #8

Closed
Veal-Uneasily4 opened this issue Dec 14, 2023 · 22 comments · Fixed by #13
Closed

Some issues #8

Veal-Uneasily4 opened this issue Dec 14, 2023 · 22 comments · Fixed by #13

Comments

@Veal-Uneasily4
Copy link

Veal-Uneasily4 commented Dec 14, 2023

  1. These commands not working properly after installing the plugin:
    amx_map , changelevel, rcon restart.
    Instead of restarting/changing to the desired map, it choosing a random map from the default Mod.

Does the plugin support that? if not, would be nice to see that supported (or maybe through a separate command),
as it's crucial in some servers... (I can't use the plugin without it 😞)

  1. I'm using a spec bot plugin (two bots in spec with server ip/site),
    and sometimes after changing map, it duplicates them.
    Also, it counts them for starting the "rtv".
    So if a player is alone, he can't rtv by himself, cause of the two bots that needs to rtv as well.

  2. Can you make it show more than 9 Mods/Maps?

@Veal-Uneasily4 Veal-Uneasily4 changed the title amx_map not working correctly restart map + changelevel not working correctly Dec 14, 2023
@Veal-Uneasily4 Veal-Uneasily4 changed the title restart map + changelevel not working correctly Some issues Dec 14, 2023
@FEDERICOMB96
Copy link
Owner

Hi,

  1. You must change the map with the 'amx_multimod' command that opens a menu where you must select the mode first and then the map to change from that mode. The plugin considers any other way of map change as a wrong way so it will always return to the first mode in the list.

  2. I forgot to exclude the bots from the ‘rtv’ vote, good point. I’ll keep that in mind for the next version.

  3. I have not considered increasing the number of options since the limit for a menu is 9. So I considered that limit. It is designed to exclude the current mode/map in the vote and recent modes/maps, which makes all modes and maps playable at some point, otherwise players may always vote for the same thing. I think it would be complex at this point to change all the voting menus, but maybe I will try in the future.

@Veal-Uneasily4
Copy link
Author

Veal-Uneasily4 commented Jan 4, 2024

Hi,

  1. You must change the map with the 'amx_multimod' command that opens a menu where you must select the mode first and then the map to change from that mode. The plugin considers any other way of map change as a wrong way so it will always return to the first mode in the list.
  2. I forgot to exclude the bots from the ‘rtv’ vote, good point. I’ll keep that in mind for the next version.
  3. I have not considered increasing the number of options since the limit for a menu is 9. So I considered that limit. It is designed to exclude the current mode/map in the vote and recent modes/maps, which makes all modes and maps playable at some point, otherwise players may always vote for the same thing. I think it would be complex at this point to change all the voting menus, but maybe I will try in the future.

amx_multimod not working for me properly.
when selecting anything from the amx_multimod menu it closing the menu.

-does any of these should be disabled?

nextmap.amxx
mapchooser.amxx
timeleft.amxx

@FEDERICOMB96
Copy link
Owner

amx_multimod not working for me properly.
when selecting anything from the amx_multimod menu it closing the menu.

I just tested the command and it works correctly. Are you using the version compiled by Git or a modified version? 🤔

-does any of these should be disabled?

nextmap.amxx mapchooser.amxx timeleft.amxx

All those that you just mentioned. The plugin already includes the ‘timeleft’, ‘nextmod’, ‘nextmap’, etc commands and the entire map voting system. So you don't need any additional plugin for this purpose. 😄

@Veal-Uneasily4
Copy link
Author

amx_multimod not working for me properly.
when selecting anything from the amx_multimod menu it closing the menu.

I just tested the command and it works correctly. Are you using the version compiled by Git or a modified version? 🤔

-does any of these should be disabled?
nextmap.amxx mapchooser.amxx timeleft.amxx

All those that you just mentioned. The plugin already includes the ‘timeleft’, ‘nextmod’, ‘nextmap’, etc commands and the entire map voting system. So you don't need any additional plugin for this purpose. 😄

version compiled by git

@FEDERICOMB96
Copy link
Owner

amx_multimod not working for me properly.
when selecting anything from the amx_multimod menu it closing the menu.

I just tested the command and it works correctly. Are you using the version compiled by Git or a modified version? 🤔

-does any of these should be disabled?
nextmap.amxx mapchooser.amxx timeleft.amxx

All those that you just mentioned. The plugin already includes the ‘timeleft’, ‘nextmod’, ‘nextmap’, etc commands and the entire map voting system. So you don't need any additional plugin for this purpose. 😄

version compiled by git

Do you have admin access? See "addons/amxmodx/configs/multimod_manager/configs.json" -> "adminflags" for menu access

@Veal-Uneasily4
Copy link
Author

Veal-Uneasily4 commented Jan 14, 2024

amx_multimod not working for me properly.
when selecting anything from the amx_multimod menu it closing the menu.

I just tested the command and it works correctly. Are you using the version compiled by Git or a modified version? 🤔

-does any of these should be disabled?
nextmap.amxx mapchooser.amxx timeleft.amxx

All those that you just mentioned. The plugin already includes the ‘timeleft’, ‘nextmod’, ‘nextmap’, etc commands and the entire map voting system. So you don't need any additional plugin for this purpose. 😄

version compiled by git

Do you have admin access? See "addons/amxmodx/configs/multimod_manager/configs.json" -> "adminflags" for menu access

yes

@FEDERICOMB96
Copy link
Owner

amx_multimod not working for me properly.
when selecting anything from the amx_multimod menu it closing the menu.

I just tested the command and it works correctly. Are you using the version compiled by Git or a modified version? 🤔

-does any of these should be disabled?
nextmap.amxx mapchooser.amxx timeleft.amxx

All those that you just mentioned. The plugin already includes the ‘timeleft’, ‘nextmod’, ‘nextmap’, etc commands and the entire map voting system. So you don't need any additional plugin for this purpose. 😄

version compiled by git

Do you have admin access? See "addons/amxmodx/configs/multimod_manager/configs.json" -> "adminflags" for menu access

yes

So I don't know exactly the reason for the problem 🤔 . Try placing the plugin at the top of the plugins list in "plugins.ini"

@Veal-Uneasily4
Copy link
Author

amx_multimod not working for me properly.
when selecting anything from the amx_multimod menu it closing the menu.

I just tested the command and it works correctly. Are you using the version compiled by Git or a modified version? 🤔

-does any of these should be disabled?
nextmap.amxx mapchooser.amxx timeleft.amxx

All those that you just mentioned. The plugin already includes the ‘timeleft’, ‘nextmod’, ‘nextmap’, etc commands and the entire map voting system. So you don't need any additional plugin for this purpose. 😄

version compiled by git

Do you have admin access? See "addons/amxmodx/configs/multimod_manager/configs.json" -> "adminflags" for menu access

yes

So I don't know exactly the reason for the problem 🤔 . Try placing the plugin at the top of the plugins list in "plugins.ini"

Still not working 😢
Anything else to try/check?
Do you have I might have some problem with the jason config?

@FEDERICOMB96
Copy link
Owner

amx_multimod not working for me properly.
when selecting anything from the amx_multimod menu it closing the menu.

I just tested the command and it works correctly. Are you using the version compiled by Git or a modified version? 🤔

-does any of these should be disabled?
nextmap.amxx mapchooser.amxx timeleft.amxx

All those that you just mentioned. The plugin already includes the ‘timeleft’, ‘nextmod’, ‘nextmap’, etc commands and the entire map voting system. So you don't need any additional plugin for this purpose. 😄

version compiled by git

Do you have admin access? See "addons/amxmodx/configs/multimod_manager/configs.json" -> "adminflags" for menu access

yes

So I don't know exactly the reason for the problem 🤔 . Try placing the plugin at the top of the plugins list in "plugins.ini"

Still not working 😢 Anything else to try/check? Do you have I might have some problem with the jason config?

Post the file here for review it

@Veal-Uneasily4
Copy link
Author

Veal-Uneasily4 commented Feb 13, 2024

amx_multimod not working for me properly.
when selecting anything from the amx_multimod menu it closing the menu.

I just tested the command and it works correctly. Are you using the version compiled by Git or a modified version? 🤔

-does any of these should be disabled?
nextmap.amxx mapchooser.amxx timeleft.amxx

All those that you just mentioned. The plugin already includes the ‘timeleft’, ‘nextmod’, ‘nextmap’, etc commands and the entire map voting system. So you don't need any additional plugin for this purpose. 😄

version compiled by git

Do you have admin access? See "addons/amxmodx/configs/multimod_manager/configs.json" -> "adminflags" for menu access

yes

So I don't know exactly the reason for the problem 🤔 . Try placing the plugin at the top of the plugins list in "plugins.ini"

Still not working 😢 Anything else to try/check? Do you have I might have some problem with the jason config?

Post the file here for review it
--

@FEDERICOMB96
Copy link
Owner

@Veal-Uneasily4
Everything seems to be fine. I tested it on a vanilla server, and it worked correctly. You should try it on a test server and verify that it works; then you’ll know if any add-on from your mods is interfering with the menu.

@Veal-Uneasily4
Copy link
Author

@Veal-Uneasily4 Everything seems to be fine. I tested it on a vanilla server, and it worked correctly. You should try it on a test server and verify that it works; then you’ll know if any add-on from your mods is interfering with the menu.

Hey,
I selected every option possible using cmd: "amx_multimod" in console,
nothing worked, and it shows this in error_**.log:

L 04/09/2024 - 17:39:25: [AMXX] Displaying debug trace (plugin "multimod_manager.amxx", version "v2.2.209")
L 04/09/2024 - 17:39:25: [AMXX] Run time error 8: heap low 
L 04/09/2024 - 17:39:25: [AMXX]    [0] admincmds.inc::ShowMenu_SelectMod (line 198)
L 04/09/2024 - 17:39:25: [AMXX]    [1] admincmds.inc::menu_AdminMultimod (line 160)
L 04/09/2024 - 17:39:27: [AMXX] Displaying debug trace (plugin "multimod_manager.amxx", version "v2.2.209")
L 04/09/2024 - 17:39:27: [AMXX] Run time error 8: heap low 
L 04/09/2024 - 17:39:27: [AMXX]    [0] admincmds.inc::ShowMenu_SelectMap (line 254)
L 04/09/2024 - 17:39:27: [AMXX]    [1] admincmds.inc::menu_AdminMultimod (line 161)
L 04/09/2024 - 17:39:31: [AMXX] Displaying debug trace (plugin "multimod_manager.amxx", version "v2.2.209")
L 04/09/2024 - 17:39:31: [AMXX] Run time error 8: heap low 
L 04/09/2024 - 17:39:31: [AMXX]    [0] admincmds.inc::ShowMenu_Votemod (line 355)
L 04/09/2024 - 17:39:31: [AMXX]    [1] admincmds.inc::menu_AdminMultimod (line 167)
L 04/09/2024 - 17:39:38: [AMXX] Displaying debug trace (plugin "multimod_manager.amxx", version "v2.2.209")
L 04/09/2024 - 17:39:38: [AMXX] Run time error 8: heap low 
L 04/09/2024 - 17:39:38: [AMXX]    [0] admincmds.inc::IsFullSelected (line 1257)
L 04/09/2024 - 17:39:38: [AMXX]    [1] admincmds.inc::ShowMenu_Votemap (line 674)
L 04/09/2024 - 17:39:38: [AMXX]    [2] admincmds.inc::menu_SelectVoteMap (line 720)

@Maxi605
Copy link

Maxi605 commented Apr 10, 2024

Can't reproduce the original issue. Are you still unable to use changelevel command?
If so, i'll recommend to re-install your server, something is wrong and it's not the external plugin.

@Veal-Uneasily4
Copy link
Author

Can't reproduce the original issue. Are you still unable to use changelevel command? If so, i'll recommend to re-install your server, something is wrong and it's not the external plugin.

changelevel command is working as intended, But it's not - when the MultiMod plugin is disabled.
And the author said it's normal like that, and must use amx_multimod to change map.
So I don't see a reason why I need to reinstall my server.

I sent the errors I get when using that command above your message (error: heap low).

@FEDERICOMB96
Copy link
Owner

@Veal-Uneasily4 Everything seems to be fine. I tested it on a vanilla server, and it worked correctly. You should try it on a test server and verify that it works; then you’ll know if any add-on from your mods is interfering with the menu.

Hey, I selected every option possible using cmd: "amx_multimod" in console, nothing worked, and it shows this in error_**.log:

L 04/09/2024 - 17:39:25: [AMXX] Displaying debug trace (plugin "multimod_manager.amxx", version "v2.2.209")
L 04/09/2024 - 17:39:25: [AMXX] Run time error 8: heap low 
L 04/09/2024 - 17:39:25: [AMXX]    [0] admincmds.inc::ShowMenu_SelectMod (line 198)
L 04/09/2024 - 17:39:25: [AMXX]    [1] admincmds.inc::menu_AdminMultimod (line 160)
L 04/09/2024 - 17:39:27: [AMXX] Displaying debug trace (plugin "multimod_manager.amxx", version "v2.2.209")
L 04/09/2024 - 17:39:27: [AMXX] Run time error 8: heap low 
L 04/09/2024 - 17:39:27: [AMXX]    [0] admincmds.inc::ShowMenu_SelectMap (line 254)
L 04/09/2024 - 17:39:27: [AMXX]    [1] admincmds.inc::menu_AdminMultimod (line 161)
L 04/09/2024 - 17:39:31: [AMXX] Displaying debug trace (plugin "multimod_manager.amxx", version "v2.2.209")
L 04/09/2024 - 17:39:31: [AMXX] Run time error 8: heap low 
L 04/09/2024 - 17:39:31: [AMXX]    [0] admincmds.inc::ShowMenu_Votemod (line 355)
L 04/09/2024 - 17:39:31: [AMXX]    [1] admincmds.inc::menu_AdminMultimod (line 167)
L 04/09/2024 - 17:39:38: [AMXX] Displaying debug trace (plugin "multimod_manager.amxx", version "v2.2.209")
L 04/09/2024 - 17:39:38: [AMXX] Run time error 8: heap low 
L 04/09/2024 - 17:39:38: [AMXX]    [0] admincmds.inc::IsFullSelected (line 1257)
L 04/09/2024 - 17:39:38: [AMXX]    [1] admincmds.inc::ShowMenu_Votemap (line 674)
L 04/09/2024 - 17:39:38: [AMXX]    [2] admincmds.inc::menu_SelectVoteMap (line 720)

Hi, now I can see the error you have more clearly. I think it might be my mistake to use the native “fmt” inside another “fmt,” which could be causing the error. It could also be related to the language you are using for the menu. In my case, it was tested with the “Spanish” language, and there were no issues. [If you can let me know which language you are using and check if you encounter the same error in another language, I will try to send a commit to fix the issue with the use of “fmt”

@Veal-Uneasily4
Copy link
Author

@Veal-Uneasily4 Everything seems to be fine. I tested it on a vanilla server, and it worked correctly. You should try it on a test server and verify that it works; then you’ll know if any add-on from your mods is interfering with the menu.

Hey, I selected every option possible using cmd: "amx_multimod" in console, nothing worked, and it shows this in error_**.log:

L 04/09/2024 - 17:39:25: [AMXX] Displaying debug trace (plugin "multimod_manager.amxx", version "v2.2.209")
L 04/09/2024 - 17:39:25: [AMXX] Run time error 8: heap low 
L 04/09/2024 - 17:39:25: [AMXX]    [0] admincmds.inc::ShowMenu_SelectMod (line 198)
L 04/09/2024 - 17:39:25: [AMXX]    [1] admincmds.inc::menu_AdminMultimod (line 160)
L 04/09/2024 - 17:39:27: [AMXX] Displaying debug trace (plugin "multimod_manager.amxx", version "v2.2.209")
L 04/09/2024 - 17:39:27: [AMXX] Run time error 8: heap low 
L 04/09/2024 - 17:39:27: [AMXX]    [0] admincmds.inc::ShowMenu_SelectMap (line 254)
L 04/09/2024 - 17:39:27: [AMXX]    [1] admincmds.inc::menu_AdminMultimod (line 161)
L 04/09/2024 - 17:39:31: [AMXX] Displaying debug trace (plugin "multimod_manager.amxx", version "v2.2.209")
L 04/09/2024 - 17:39:31: [AMXX] Run time error 8: heap low 
L 04/09/2024 - 17:39:31: [AMXX]    [0] admincmds.inc::ShowMenu_Votemod (line 355)
L 04/09/2024 - 17:39:31: [AMXX]    [1] admincmds.inc::menu_AdminMultimod (line 167)
L 04/09/2024 - 17:39:38: [AMXX] Displaying debug trace (plugin "multimod_manager.amxx", version "v2.2.209")
L 04/09/2024 - 17:39:38: [AMXX] Run time error 8: heap low 
L 04/09/2024 - 17:39:38: [AMXX]    [0] admincmds.inc::IsFullSelected (line 1257)
L 04/09/2024 - 17:39:38: [AMXX]    [1] admincmds.inc::ShowMenu_Votemap (line 674)
L 04/09/2024 - 17:39:38: [AMXX]    [2] admincmds.inc::menu_SelectVoteMap (line 720)

Hi, now I can see the error you have more clearly. I think it might be my mistake to use the native “fmt” inside another “fmt,” which could be causing the error. It could also be related to the language you are using for the menu. In my case, it was tested with the “Spanish” language, and there were no issues. [If you can let me know which language you are using and check if you encounter the same error in another language, I will try to send a commit to fix the issue with the use of “fmt”

The language I use in server is english.

I changed amx_lang "es" in server to try with spanish,
and got the same errors actually.

@FEDERICOMB96 FEDERICOMB96 linked a pull request Apr 16, 2024 that will close this issue
@FEDERICOMB96
Copy link
Owner

@Veal-Uneasily4 Can you test the changes? #13 Download from "Actions"

@Veal-Uneasily4
Copy link
Author

Veal-Uneasily4 commented Apr 16, 2024

@Veal-Uneasily4 Can you test the changes? #13 Download from "Actions"

Fixed: options 1-3 now works without any issues

Not fixed: options 4-5 (Start a vote mod/map) not working;
It shows these errors:

L 04/16/2024 - 17:41:19: [AMXX] Displaying debug trace (plugin "multimod_manager.amxx", version "v2.2.209")
L 04/16/2024 - 17:41:19: [AMXX] Run time error 8: heap low 
L 04/16/2024 - 17:41:19: [AMXX]    [0] admincmds.inc::IsFullSelected (line 1284)
L 04/16/2024 - 17:41:19: [AMXX]    [1] admincmds.inc::ShowMenu_Votemod (line 404)
L 04/16/2024 - 17:41:19: [AMXX]    [2] admincmds.inc::menu_SelectVoteMod (line 453)
L 04/16/2024 - 17:41:23: [AMXX] Displaying debug trace (plugin "multimod_manager.amxx", version "v2.2.209")
L 04/16/2024 - 17:41:23: [AMXX] Run time error 8: heap low 
L 04/16/2024 - 17:41:23: [AMXX]    [0] admincmds.inc::IsFullSelected (line 1284)
L 04/16/2024 - 17:41:23: [AMXX]    [1] admincmds.inc::ShowMenu_Votemap (line 701)
L 04/16/2024 - 17:41:23: [AMXX]    [2] admincmds.inc::menu_SelectVoteMap (line 747)

Also got some questions:

  1. How can players rtv to change to other map in the same mod?
    as for now, when they rtv it excludes the current mod.

  2. What's the purpose of the mod_tag?
    How to make "change_game_description" to use the mod_tag instead of modname?

@FEDERICOMB96
Copy link
Owner

Not fixed: options 4-5 (Start a vote mod/map) not working; It shows these errors:

I pushed new commit, can you test it? Don't forget to replace the lang file.

@FEDERICOMB96
Copy link
Owner

Also got some questions:

  1. How can players rtv to change to other map in the same mod?
    as for now, when they rtv it excludes the current mod.
  2. What's the purpose of the mod_tag?
    How to make "change_game_description" to use the mod_tag instead of modname?
  1. The original idea behind the “rtv” command is to switch the map; however, I’ve used it here to change the mode/map. I can’t think of a way to alter this without breaking current compatibility, perhaps by creating a new command solely for changing the map within the current mode. If you have any ideas to suggest, I'll read them. 😄
  2. I will make changes to the config file to add support for that.

@Veal-Uneasily4
Copy link
Author

I pushed new commit, can you test it? Don't forget to replace the lang file.

Now it's working,
But still shows other errors in log. but again at least now it's working;

L 04/18/2024 - 05:12:16: [AMXX] Displaying debug trace (plugin "multimod_manager.amxx", version "v2.2.209")
L 04/18/2024 - 05:12:16: [AMXX] Run time error 8: heap low 
L 04/18/2024 - 05:12:16: [AMXX]    [0] admincmds.inc::menu_StartCustomVotemod (line 522)
L 04/18/2024 - 05:12:34: [AMXX] Displaying debug trace (plugin "multimod_manager.amxx", version "v2.2.209")
L 04/18/2024 - 05:12:34: [AMXX] Run time error 8: heap low 
L 04/18/2024 - 05:12:34: [AMXX]    [0] admincmds.inc::menu_StartCustomVotemap (line 821)
  1. The original idea behind the “rtv” command is to switch the map; however, I’ve used it here to change the mode/map. I can’t think of a way to alter this without breaking current compatibility, perhaps by creating a new command solely for changing the map within the current mode. If you have any ideas to suggest, I'll read them. 😄
  2. I will make changes to the config file to add support for that.
  1. Why can't add the current mod as an option in the "rtv" command as well?
    like how you did with the "mm_force_votemod" command, that it shows an option to "extend the mod for 15 minutes".

  2. Thanks 👍

@FEDERICOMB96
Copy link
Owner

But still shows other errors in log. but again at least now it's working;

Fixed!

  1. Why can't add the current mod as an option in the "rtv" command as well?
    like how you did with the "mm_force_votemod" command, that it shows an option to "extend the mod for 15 minutes".

I'll think about the best way to implement your idea. I'll open a new PR after I finish fixing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants