From 21220e149dc2296412544c384ffcb52d6cdbf9ea Mon Sep 17 00:00:00 2001 From: LTS-FFXIV <127939494+LTS-FFXIV@users.noreply.github.com> Date: Sun, 22 Sep 2024 01:58:36 -0500 Subject: [PATCH] Add checks to prevent redundant LightspeedPvE usage Enhanced the `AttackAbility` method in `AST_Default.cs` to include conditions that ensure `Lightspeed` status is not active before using `LightspeedPvE`. This prevents unnecessary usage of the `LightspeedPvE` ability when the `Lightspeed` status is already applied to the player. --- BasicRotations/Healer/AST_Default.cs | 12 +++++++++--- BasicRotations/RebornRotations.csproj | 2 +- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/BasicRotations/Healer/AST_Default.cs b/BasicRotations/Healer/AST_Default.cs index 1ef0025..2b2a882 100644 --- a/BasicRotations/Healer/AST_Default.cs +++ b/BasicRotations/Healer/AST_Default.cs @@ -179,18 +179,24 @@ protected override bool AttackAbility(IAction nextGCD, out IAction? act) act = null; if (BubbleProtec && Player.HasStatus(true, StatusID.CollectiveUnconscious_848)) return false; - if (InCombat && DivinationPvE.Cooldown.ElapsedAfter(115) && LightspeedPvE.CanUse(out act, usedUp: true)) return true; + if (!Player.HasStatus(true, StatusID.Lightspeed) + && InCombat + && DivinationPvE.Cooldown.ElapsedAfter(115) + && LightspeedPvE.CanUse(out act, usedUp: true)) return true; if (IsBurst && !IsMoving && DivinationPvE.CanUse(out act)) return true; if (AstralDrawPvE.CanUse(out act, usedUp: IsBurst)) return true; - if ((InBurstStatus || DivinationPvE.Cooldown.ElapsedAfter(115)) && InCombat && LightspeedPvE.CanUse(out act, usedUp: true)) return true; + if (!Player.HasStatus(true, StatusID.Lightspeed) + && (InBurstStatus || DivinationPvE.Cooldown.ElapsedAfter(115)) + && InCombat + && LightspeedPvE.CanUse(out act, usedUp: true)) return true; if (InCombat) { - if (IsMoving && LightspeedPvE.CanUse(out act, usedUp: LightspeedMove)) return true; + if (!Player.HasStatus(true, StatusID.Lightspeed) && IsMoving && LightspeedPvE.CanUse(out act, usedUp: LightspeedMove)) return true; if (!IsMoving) { diff --git a/BasicRotations/RebornRotations.csproj b/BasicRotations/RebornRotations.csproj index 37ed4ca..b9e3288 100644 --- a/BasicRotations/RebornRotations.csproj +++ b/BasicRotations/RebornRotations.csproj @@ -16,7 +16,7 @@ - +