From 980b68d38aab4b676b212908a8353dbd9d18857d Mon Sep 17 00:00:00 2001 From: Four-amer Date: Fri, 27 Sep 2024 11:25:23 +0200 Subject: [PATCH] Adjusted `WillHaveXCharges` - Leftover debug text for bard - `WillHaveXCharges` Fix From my testing `requiredTime` in `WillHaveXCharges` was always one recast time too much. For example if we have Bard with 1 charge of bloodletter and `charges` is 2 then `requiredTime` was 15 when it probably should have been 0. --- RotationSolver.Basic/Actions/ActionCooldownInfo.cs | 2 +- RotationSolver.Basic/Rotations/Basic/BardRotation.cs | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/RotationSolver.Basic/Actions/ActionCooldownInfo.cs b/RotationSolver.Basic/Actions/ActionCooldownInfo.cs index 38428567f..822b43d64 100644 --- a/RotationSolver.Basic/Actions/ActionCooldownInfo.cs +++ b/RotationSolver.Basic/Actions/ActionCooldownInfo.cs @@ -169,7 +169,7 @@ public bool WillHaveXCharges(uint charges, float remain) if (charges <= CurrentCharges) return true; - float requiredTime = (charges - CurrentCharges) * RecastTimeOneChargeRaw; + float requiredTime = (charges - CurrentCharges - 1) * RecastTimeOneChargeRaw; return RecastTimeRemainOneCharge <= remain - requiredTime; } diff --git a/RotationSolver.Basic/Rotations/Basic/BardRotation.cs b/RotationSolver.Basic/Rotations/Basic/BardRotation.cs index c4ac5cff0..7a1857951 100644 --- a/RotationSolver.Basic/Rotations/Basic/BardRotation.cs +++ b/RotationSolver.Basic/Rotations/Basic/BardRotation.cs @@ -63,6 +63,7 @@ public override void DisplayStatus() ImGui.Text("SongTimeRaw: " + SongTimeRaw.ToString()); ImGui.Text("SongTime: " + SongTime.ToString()); ImGui.Text("BloodletterMax: " + BloodletterMax.ToString()); + ImGui.Text("Bloodlettercharges: " + BloodletterPvE.Cooldown.CurrentCharges.ToString()); } #endregion