Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] RSR making several thousands of the data cache tag "Avarice.ActionOverride" #169

Closed
BrakusTapus opened this issue Jun 9, 2024 · 3 comments

Comments

@BrakusTapus
Copy link
Contributor

RSR version: v4.1.1.9

As soon as RSR is on thousands of these will be made until user either turns RSR off completely or closes the game.
Occurs when Avarice is not installed or is installed.
Is this intentional?

image
ffxiv_dx11_Ij0U5wZP7h

@spaceelysian
Copy link
Contributor

private static void SetAction(uint id) => Svc.PluginInterface.GetOrCreateData( "Avarice.ActionOverride", ( ) => new List<uint>( ) {id} ) [0] = id;

I think it has something to do with this bit of code. Is it because a new list is created every time?

@BrakusTapus
Copy link
Contributor Author

private static void SetAction(uint id) => Svc.PluginInterface.GetOrCreateData( "Avarice.ActionOverride", ( ) => new List<uint>( ) {id} ) [0] = id;

I think it has something to do with this bit of code. Is it because a new list is created every time?

Yeah it's creating a new list because of that line of code, the same bug was present in the orginal RS but has been fixed

ArchiDog1998/RotationSolver#623

@NostraThomas99
Copy link
Contributor

Fixed in #172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants