Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CV Form is buggy on creation and edit mode #928

Closed
TheCommandCat opened this issue Jan 10, 2025 · 1 comment
Closed

CV Form is buggy on creation and edit mode #928

TheCommandCat opened this issue Jan 10, 2025 · 1 comment

Comments

@TheCommandCat
Copy link
Contributor

Description

There's a problem with the CV form fields being read-only when they shouldn't be

On JA:

When creating:

  • Can't create CV forms (is this on purpose? Should it be changed?)

When editing:

  • Can fill "פעולות שננקטו"
  • Can fill "טופל על ידי"
  • All other fields can't be edited

On Tournament Manager:

When creating:

  • Can't fill "פעולות שננקטו"
  • Can't fill "טופל על ידי"
  • All other fields work fine

When editing:

  • Nothing can be edited (It might be on purpose, just wants to be sure)

How to Reproduce

  1. Log in as the Tournament Manager (TM):

    • Try to create a CV form
    • Try to edit an existing CV form and check if any fields are editable
  2. Log in as the JA:

    • Try to edit a CV form and check which fields are editable

Conclusion

The main issue is that the Tournament Manager (the only one who can create CV forms right now) can't fill the last 2 fields, while only the JA can edit them.

Can someone explain what permissions each user is supposed to have on CV forms?

@johnmeshulam
Copy link
Member

This is not an issue, but rather documentation that is currently not written. JA can't fill CV forms, JA deals with cv forms that have been filled. For the same reason when filling out CV forms you cannot edit the fields that describe how you handled the CV form since that's the JA's job.

@github-project-automation github-project-automation bot moved this from Backlog to Done in LEMS Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants