Memory leak

[navossoc]

Well, I've used this extension for less than one day.

After 4 hours running my web server runs out of memory ;)

You allocated memory and never freed it later.

In two places here:
https://github.com/AllTheDucks/hsts-iis-module/blob/d18839e99474478bf63666109e6255099092b959/module/src/module/cpp/HstsIisModule.cpp#L120
https://github.com/AllTheDucks/hsts-iis-module/blob/d18839e99474478bf63666109e6255099092b959/module/src/module/cpp/HstsIisModule.cpp#L125

TBH, I'm not sure why you alloc and free this strings on every request since they are constants.
Can't you just move it to some kind of initialization and alloc and free it once?

Besides that, I think you may have another leak here:
https://github.com/AllTheDucks/hsts-iis-module/blob/d18839e99474478bf63666109e6255099092b959/module/src/module/cpp/HstsIisModule.cpp#L277

You may need to add a call to cleanup before return.

Something like this:

pHttpResponse->Redirect(url, true, false);
cleanup();
return RQ_NOTIFICATION_FINISH_REQUEST;

I did not analyze all the source, I just gave a quick peek.

[FWest98]

Thanks for the heads-up! I see that this is indeed a problem that needs fixing.
Currently I don't have much time (exams and stuff) and I can't get the build working (some update messed up the compilation tools). I was planning to install a fresh W10 in a few weeks, then I'll certainly look into this. I have some other things to update to this project as well.

[FWest98]

I finally got time to fix this, and you were completely right. Those were indeed bad memory leaks so I fixed them in the most recent release, 2.2.0. Thanks for your help!