Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parcellation features returning incorrect data #100

Closed
fsdavid opened this issue May 18, 2022 · 5 comments
Closed

Parcellation features returning incorrect data #100

fsdavid opened this issue May 18, 2022 · 5 comments
Assignees

Comments

@fsdavid
Copy link

fsdavid commented May 18, 2022

/atlases/{atlas_id}/parcellations/{parcellation_id}/features endpoint does not return data correctly. description, dataset_id, and other fields are not included on the returned json, but they are inside the name field which looks like this:

name: "... {'name': '...', 'dataset_id': '...', 'description': '...', 'citation': '...', 'authors': [...], 'cohort': '...', 'subject': '...', 'filename': '...'}"

... - is filled with relevant data

@xgui3783
Copy link
Member

endpoint schema looks like : spec

re: name property erroenous: @marcenko fixed it in FZJ-INM1-BDA/siibra-python@2dbd8aa . The change is not live (yet) because okd-dev admin panel is currently broken (pods are still online).

re: other fields, which fields do you actually need?

@fsdavid
Copy link
Author

fsdavid commented May 18, 2022

Great. We need description. For now, not sure if we need citation and authors separately, but would be nice to have them as part of the description.

@xgui3783 xgui3783 self-assigned this May 18, 2022
@fsdavid
Copy link
Author

fsdavid commented May 18, 2022

dataset name would be nice as well. So, would be nice to get the dataset info:
dataset: {'name': '...', 'dataset_id': '...', 'description': '...', 'citation': '...', 'authors': [...], 'cohort': '...', 'subject': '...', 'filename': '...'}

@xgui3783
Copy link
Member

we will see what we can do.

Not a promise, but we will look into if it is resource intensive to retrieve some/all of the aforementioned fields.

@xgui3783
Copy link
Member

should be fixed. e.g.:

curl -X 'GET'   'https://siibra-api-dev.apps-dev.hbp.eu/v2_0/atlases/human/parcellations/2.9/features?page=1&size=1'   -H 'accept: application/json'  | jq '.items[0] | keys'

returns

[
  "@id",
  "@type",
  "authors",
  "citation",
  "cohort",
  "columns",
  "dataset_id",
  "description",
  "filename",
  "matrix",
  "name",
  "parcellations",
  "subject"
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants