Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag queries should use slug instead of name #33

Open
gelhaimer opened this issue May 6, 2017 · 0 comments
Open

Tag queries should use slug instead of name #33

gelhaimer opened this issue May 6, 2017 · 0 comments

Comments

@gelhaimer
Copy link

gelhaimer commented May 6, 2017

Hello,

Nice work on this bundle.

I've some trouble to figure out why the tag queries use the name attributes instead of the slug.
As the slug guarantees the unicity of a tag, asking for a tag which does correspond to the slug but the name should return the given tag.
This behavior should also be working when getting ressources from a tag.

Considering the tag "This is a tag", and its slug "this-is-a-tag", then

$tagRepo->getResourceIdsForTag('article_tag', 'this-is-a-tag'));

should return all the ressources linked to "This is a tag". In this case, nothing will be returned as the tag corresponds to nothing existing in name colum of tag table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant