Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retract should be extend #3914

Closed
dthusian opened this issue Jul 15, 2024 · 0 comments · Fixed by #3930
Closed

retract should be extend #3914

dthusian opened this issue Jul 15, 2024 · 0 comments · Fixed by #3930

Comments

@dthusian
Copy link

The 4th argument on PistonBlock#move is named boolean retract. However, this doesn't match the observed usage of this argument in the decompiled code. I ran some testing with a mixin, and it seems like the argument is true when pushing.

I propose that the argument should be renamed to extend or something similar.

Yarn version is 1.21+build.9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename PistonBlock#move boolean argument to 'extend' Octol1ttle/yarn
1 participant
@dthusian