Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify developmentDependency=true in packages #22

Closed
thomaslevesque opened this issue May 15, 2020 · 3 comments · Fixed by #23
Closed

Specify developmentDependency=true in packages #22

thomaslevesque opened this issue May 15, 2020 · 3 comments · Fixed by #23
Labels
enhancement New feature or request
Milestone
6.1.0

Comments

@thomaslevesque
Copy link
Member

So that the packages are correctly installed with PrivateAssets="all".

Note: developmentDependency is a property in the nuspec file, not sure how to set it from the csproj yet.
@thomaslevesque thomaslevesque mentioned this issue May 18, 2020
Merged
@blairconrad blairconrad added this to the vNext milestone May 18, 2020
@blairconrad
Copy link
Member

Sir, do you consider this to be a bug fix, or an enhancement? I'll label as enhancement for now. If you want to change, do!

@blairconrad blairconrad added the enhancement New feature or request label May 18, 2020
@thomaslevesque
Copy link
Member Author

I'd say enhancement. It's arguably more correct this way, but it wasn't really a bug.

@afakebot
Copy link

This change has been released as part of FakeItEasy.Analyzers 6.1.0.

This was referenced Mar 17, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
6.1.0
Development

Successfully merging a pull request may close this issue.

Add developmentDependency=true in packages thomaslevesque/FakeItEasy.Analyzers
3 participants
@thomaslevesque @blairconrad @afakebot