You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If you pass Flay Mind something that isn't an entity in the place where it's expecting an entity, the function shown below causes a mishap:
However, entity.mob is not a valid lang key, and thus you get a mishap message that looks something like this:
This could be fixed in a variety of ways. A new lang entry could be added for entity.mob, but I don't think this is actually necessary. There's already one for entity.living, so the getMob() function could just be changed to use that instead.
Alternatively, getMob() could be removed entirely (it's only used for OpBrainsweep) and replaced with the nearly identical getLivingEntityButNotArmorStand() function which is currently used in OpPotionEffect. This would, however, require changing various bits of brainsweep-related code to expect a LivingEntity rather than a Mob.
Steps to reproduce
Attempt to cast Flay Mind with something other than an entity as the first argument
Observe broken mishap message
Observe that the mishap.invalid_value.class.entity section of the lang file doesn't have an entry for mob
The text was updated successfully, but these errors were encountered:
Robotgiggle
changed the title
Mishap when giving Flay Mind something other than an entity gives a broken lang key
Mishap for providing something other than an entity as Flay Mind's first argument has a broken lang key
Jan 16, 2025
Modloader
Forge, Fabric
Minecraft version
1.20.1
Hex Casting version
0.11.2
Issue description
If you pass Flay Mind something that isn't an entity in the place where it's expecting an entity, the function shown below causes a mishap:
However,
entity.mob
is not a valid lang key, and thus you get a mishap message that looks something like this:This could be fixed in a variety of ways. A new lang entry could be added for
entity.mob
, but I don't think this is actually necessary. There's already one forentity.living
, so the getMob() function could just be changed to use that instead.Alternatively, getMob() could be removed entirely (it's only used for OpBrainsweep) and replaced with the nearly identical getLivingEntityButNotArmorStand() function which is currently used in OpPotionEffect. This would, however, require changing various bits of brainsweep-related code to expect a LivingEntity rather than a Mob.
Steps to reproduce
mishap.invalid_value.class.entity
section of the lang file doesn't have an entry formob
The text was updated successfully, but these errors were encountered: