Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gasstation problem with Biome decoration fix which disables already decorating patch #5

Closed
quentin452 opened this issue Oct 9, 2022 · 4 comments

Comments

@quentin452
Copy link

If i use spongemixin + mixingasm i don't get theses warns
biome decoration fix : https://www.curseforge.com/minecraft/mc-mods/biome-decoration-fix/

descriptions :

when i use gasstation with biome decoration fix , i have warnings , the biome decoration fix patch is not applied and so i can still have the already decorating crash

mods list :

00gasstation-mc1.7.10-0.3.5
alreadydecoratingfix-1.0a

crash(exemple) :

crash-2022-10-08_20.55.06-server.txt

warn(exemple) :

[21:51:41] [Client thread/INFO] [STDOUT]: [net.tclproject.mysteriumlib.asm.core.MiscUtils$SystemLogHelper:warning:92]: [WARNING] Can not find the target method of fix: ASMFix: net.minecraft.world.biome.BiomeDecorator#func_150512_a(Lnet/minecraft/world/World;Ljava/util/Random;Lnet/minecraft/world/biome/BiomeGenBase;II) -> net.tclproject.mysteriumlib.asm.fixes.MysteriumPatchesFixesH#func_150512_a(Lnet/minecraft/world/biome/BiomeDecorator;Lnet/minecraft/world/World;Ljava/util/Random;Lnet/minecraft/world/biome/BiomeGenBase;II)Z, EnumReturnSetting=ON_TRUE, EnumReturnType=FIX_METHOD_RETURN_VALUE, InjectorFactory: net.tclproject.mysteriumlib.asm.core.FixInserterFactory$OnEnter, CreateMethod = false

logs :

https://paste.ee/p/eybsQ

@quentin452 quentin452 changed the title Gasstation problem with Biome decoration fix which disables the mod patch Gasstation problem with Biome decoration fix which disables already decorating patch Oct 9, 2022
@quentin452
Copy link
Author

quentin452 commented Oct 10, 2022

temporary workaround fix, downgrade gasstation to 0.3.2,warns is introduced in 0.3.3

maybe caused by ee767ed commit or 629ca36 ?

@DrParadox7
Copy link

DrParadox7 commented Oct 10, 2022

It also conflicts with Immersive Cavegen:

[12:43:14] [Client thread/INFO] [STDOUT/Forge]: [net.tclproject.mysteriumlib.asm.core.MiscUtils$SystemLogHelper:debug:87]: [DEBUG] Injecting fixes into class net.minecraft.world.gen.feature.WorldGenSand.
[12:43:14] [Client thread/INFO] [STDOUT/Forge]: [net.tclproject.mysteriumlib.asm.core.MiscUtils$SystemLogHelper:debug:87]: [DEBUG] Fixed method net.minecraft.world.gen.feature.WorldGenSand#<init>(Lnet/minecraft/block/Block;I)
[12:43:14] [Client thread/INFO] [STDOUT/Forge]: [net.tclproject.mysteriumlib.asm.core.MiscUtils$SystemLogHelper:warning:92]: [WARNING] Can not find the target method of fix: ASMFix: net.minecraft.world.gen.feature.WorldGenSand#generate(Lnet/minecraft/world/World;Ljava/util/Random;III) -> net.tclproject.mysteriumlib.asm.fixes.MysteriumPatchesFixesSand#generate(Lnet/minecraft/world/gen/feature/WorldGenSand;Lnet/minecraft/world/World;Ljava/util/Random;III)Z, EnumReturnSetting=ALWAYS, EnumReturnType=FIX_METHOD_RETURN_VALUE, InjectorFactory: net.tclproject.mysteriumlib.asm.core.FixInserterFactory$OnEnter, CreateMethod = false

@DrParadox7
Copy link

DrParadox7 commented Oct 10, 2022

maybe caused by ee767ed commit or 629ca36 ?

You can rule out 629ca36.
I've built and tested the mod and it still occurs on its prior commit (tested with 6c55ef0)

EDIT:
I've built and tested de8e31f too but without issue:

[[Client thread/INFO] [STDOUT/Forge]: net.tclproject.mysteriumlib.asm.core.MiscUtils$SystemLogHelper:debug:87]: [DEBUG] Injecting fixes into class net.minecraft.world.gen.feature.WorldGenSand.
[Client thread/INFO] [STDOUT/Forge]: [net.tclproject.mysteriumlib.asm.core.MiscUtils$SystemLogHelper:debug:87]: [DEBUG] Fixed method net.minecraft.world.gen.feature.WorldGenSand#<init>(Lnet/minecraft/block/Block;I)
[Client thread/INFO] [STDOUT/Forge]: [net.tclproject.mysteriumlib.asm.core.MiscUtils$SystemLogHelper:debug:87]: [DEBUG] Fixed method net.minecraft.world.gen.feature.WorldGenSand#generate(Lnet/minecraft/world/World;Ljava/util/Random;III)

I can confirm that e84977b is the culprit.
Technically Mysteriumlib is an ASM so the title is still on point.

@quentin452
Copy link
Author

warns fixed in 0.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants