Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeepLastFragment setting throws an unexpected error #11

Closed
FelixBaensch opened this issue Jul 13, 2023 · 2 comments · Fixed by #70
Closed

KeepLastFragment setting throws an unexpected error #11

FelixBaensch opened this issue Jul 13, 2023 · 2 comments · Fixed by #70
Assignees
@FelixBaensch
Labels
bug Something isn't working

Comments

@FelixBaensch
Copy link
Owner

If the setting "Keep last fragment in pipelining" is set to "true", a pipeline fragmentation results in an unexpected error.
@JonasSchaub JonasSchaub added the bug Something isn't working label Jul 13, 2023
@JonasSchaub JonasSchaub mentioned this issue Mar 27, 2024
Closed
@JonasSchaub
Copy link
Collaborator

@FelixBaensch do you maybe see a time slot next week where we can discuss this issue?

@JonasSchaub
Copy link
Collaborator

@JonasSchaub think about removing this setting all together, this can be handled by the fragmenters now (returned fragments setting). If it should be kept internally for now, set it to false.

@JonasSchaub JonasSchaub mentioned this issue Apr 11, 2024
Merged
@JonasSchaub JonasSchaub linked a pull request Apr 11, 2024 that will close this issue
Marked keepLastFragmentSetting for pipelines as deprecated and removed… #70
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FelixBaensch FelixBaensch

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@JonasSchaub @FelixBaensch