Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tabs closeable, including close all functionality #80

Open
JonasSchaub opened this issue Apr 16, 2024 · 3 comments
Open

Make tabs closeable, including close all functionality #80

JonasSchaub opened this issue Apr 16, 2024 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@JonasSchaub
Copy link
Collaborator

No description provided.

@JonasSchaub JonasSchaub added the enhancement New feature or request label Apr 16, 2024
@FelixBaensch
Copy link
Owner

"Close all" could be controlled by closing the molecule tab.

@JonasSchaub
Copy link
Collaborator Author

I don't really like this idea, to be honest. I think all tabs should be closeable without closing the molecules tab. I.e. when I have run a lot of fragmentations already but want to clear everything away to run a new one find it more easily. Do you see other use cases for "close all"?

@FelixBaensch
Copy link
Owner

Ok, then the "close all" is to be understood differently. I really understood it as "close all tabs (incl. Molecules tab)". But one does not exclude the other. To "only" close the results tabs, I'm with you and would take a different approach.
Please also note that it is not enough just to close the tabs, the data structures must also be cleared.

@JonasSchaub JonasSchaub added this to the MORTAR v2.0.0 milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants