Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary copyin() commands #174

Open
LinhWuerzburger opened this issue Sep 28, 2021 · 2 comments
Open

Unnecessary copyin() commands #174

LinhWuerzburger opened this issue Sep 28, 2021 · 2 comments
Assignees
@LinhWuerzburger @ChristianVonMach
Labels
bug Something isn't working as it should effort: low expected time effort: < 1 day investigate investigate if the code is correct priority: critical should be dealt with as soon as possible type: refactoring clean up and refactoring

Comments

@LinhWuerzburger
Copy link
Contributor

see #70
@LinhWuerzburger LinhWuerzburger added type: enhancement New feature or request priority: medium type: refactoring clean up and refactoring effort: low expected time effort: < 1 day labels Sep 28, 2021
@LinhWuerzburger LinhWuerzburger changed the title Unncesseary copyin() commands Unnecessary copyin() commands Sep 28, 2021
@LinhWuerzburger
Copy link
Contributor Author

by adding

#ifdef _OPENACC
   #include "accel.h"
#endif

and

#ifdef _OPENACC
    acc_present_dump();
#endif

image_2021-10-31_17-36-18
image_2021-10-31_17-36-07

presentcounter in present table dump of OpenACC raises by 1

@LinhWuerzburger
Copy link
Contributor Author

Depending on which constructor is called the copyin is necessary. Although in case it was already copied the copyin overwrites the new values on the GPU with the old values of the CPU.

@LinhWuerzburger LinhWuerzburger self-assigned this Jan 20, 2022
@LinhWuerzburger LinhWuerzburger added bug Something isn't working as it should investigate investigate if the code is correct priority: critical should be dealt with as soon as possible and removed priority: medium type: enhancement New feature or request labels Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LinhWuerzburger LinhWuerzburger

@ChristianVonMach ChristianVonMach

Labels
bug Something isn't working as it should effort: low expected time effort: < 1 day investigate investigate if the code is correct priority: critical should be dealt with as soon as possible type: refactoring clean up and refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LinhWuerzburger @ChristianVonMach