Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add warning when including files with nonmatching case #16

Closed
StanHash opened this issue Oct 15, 2018 · 0 comments · Fixed by #63
Closed

Feature Request: Add warning when including files with nonmatching case #16

StanHash opened this issue Oct 15, 2018 · 0 comments · Fixed by #63

Comments

@StanHash
Copy link
Member

The problem

Let's say we have the file EAstdlib.event; but the user writes this (and a good amount of users seem to write this):

#include "eastdlib.event" // not the same case!

If eastdlib.event is a file that exists, then all is good. But if not, this will include EAstdlib.event on Windows; but on Linux this will fail.

Inconsistent behaviour across different platforms... 😠

The suggested solution

Add a warning when the user is including a file that Core can find; but whose actual filename doesn't match.

This has the advantage of not actually breaking existing events while still notifying the user than something is wrong.

Of course this would make a lot of common events emit warnings; which may be unwanted (I don't think so personally).

The other solution to this problem I can think of is to try and find the file in a case independent way across all platforms. (I guess this would be "fixing" the assembler instead of the events; I don't really like that but I guess it's up to discussion).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant