Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in README.md under Queue Security #59

Open
chrisze opened this issue Apr 18, 2016 · 1 comment
Open

Bug in README.md under Queue Security #59

chrisze opened this issue Apr 18, 2016 · 1 comment

Comments

@chrisze
Copy link

chrisze commented Apr 18, 2016

In README.md, under Queue Security, the validate rule under rules/queue/tasks contains

newData.hasChildren(['_state', '_state_changed', '_progress']) 

Notice the presence of the _progress property. However, in queue_worker.js, in _resetTask, we have:

if (task._state === self.inProgressState) {
  task._state = self.startState;
  task._state_changed = Firebase.ServerValue.TIMESTAMP;
  task._owner = null;
  task._progress = null;
  task._error_details = null;
  return task;
}

So, if the validate rule does contain the _progress property, the transaction in queue_worker will keep failing because _progress is set to null. We should either update the doc or update queue worker.

@Caerbannog
Copy link

Is think that this issue is still applicable:
https://github.com/firebase/firebase-queue/blob/master/src/lib/queue_worker.js#L126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants