Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypedElementToSourceNodeAdapter should return IResourceTypeSupplier annotation #1174

Closed
alexzautke opened this issue Nov 17, 2019 · 0 comments · Fixed by #1175
Closed

TypedElementToSourceNodeAdapter should return IResourceTypeSupplier annotation #1174

alexzautke opened this issue Nov 17, 2019 · 0 comments · Fixed by #1175

Comments

@alexzautke
Copy link
Member

TypedElementToSourceNodeAdapter already implements IResourceTypeSupplier but does not return the annotation. In cases where the underlying SourceNode does not implement IResourceTypeSupplier (like ElementNode) consumers of TypedElementToSourceNodeAdapter may run into issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adjust TypedElementToSourceNodeAdapterTests FirelyTeam/firely-net-sdk
2 participants
@alexzautke @marcovisserFurore