Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect exception message for resourceType passed as empty in FhirJsonParser #1304

Closed
rotodd opened this issue Mar 27, 2020 · 0 comments · Fixed by #1342
Closed

Incorrect exception message for resourceType passed as empty in FhirJsonParser #1304

rotodd opened this issue Mar 27, 2020 · 0 comments · Fixed by #1342
Assignees
@marcovisserFurore
Labels
needs research

Comments

@rotodd
Copy link

rotodd commented Mar 27, 2020

Describe the bug

When calling FhirJsonParser.Parse(JsonTextReader) with a JSON resource where "resourceType": "", the exception message that is returned is type (at Cannot locate type information for type '').

To Reproduce

  1. Create a JsonTextReader object from the JSON-formatted request body of a POST request missing the resourceType value.
  2. Call FhirJsonParser.Parse(JsonTextReader)
  3. Observe that the returned exception has an incorrect message.

Expected behavior

The exception message explains that resourceType is missing.

Related issues

#876 and PR 957
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcovisserFurore marcovisserFurore

Labels
needs research
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: 1304 - also raise an exception if the ResourceType is empty FirelyTeam/firely-net-sdk
2 participants
@marcovisserFurore @rotodd