Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Validator] Detect circular references from instance to instance #465

Closed
ewoutkramer opened this issue Oct 27, 2017 · 5 comments
Closed
Assignees

Comments

@ewoutkramer
Copy link
Member

No description provided.

@marcovisserFurore
Copy link
Member

This issue has been marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@cknaap
Copy link
Member

cknaap commented Jan 12, 2022

@marcovisserFurore :I'm afraid VONK-3044 was waiting for this issue to be solved.

@ewoutkramer
Copy link
Member Author

We cannot fix this issue in the old validator - it is fixed in the new one however. Maybe a reason to move forward with the new validator...

@brianpos
Copy link
Collaborator

brianpos commented Jan 13, 2022

I put a workaround in our server to detect a couple of the cases but wasn't perfect.
Initial one was just references with '#' in them resolving to itself. Then just fail fast and not call the validator.
Happy to share the bit of code of you want it.

@cknaap
Copy link
Member

cknaap commented Jan 20, 2022

Thanks @brianpos , will take that into the refinement for our issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants