Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

live_from date not showing for scheduled changes #4420

Open
1 of 4 tasks
rolodato opened this issue Jul 30, 2024 · 1 comment
Open
1 of 4 tasks

live_from date not showing for scheduled changes #4420

rolodato opened this issue Jul 30, 2024 · 1 comment
Assignees
Labels
bug Something isn't working front-end Issue related to the React Front End Dashboard

Comments

@rolodato
Copy link
Member

How are you running Flagsmith

  • Self Hosted with Docker
  • Self Hosted with Kubernetes
  • SaaS at flagsmith.com
  • Some other way (add details in description below)

Describe the bug

When creating a scheduled change and viewing it from the Scheduling page, the go-live date is never shown.

We do have logic for this already but the banner is not being shown:

{isScheduled && (
<div className='col-md-6 mb-4'>
<InfoMessage icon='calendar' title='Scheduled Change'>
This feature change{' '}
{changeRequest?.committedAt ? 'is scheduled to' : 'will'}{' '}
go live at{' '}
{moment(scheduledDate).format('Do MMM YYYY hh:mma')}
{changeRequest?.committed_at
? ' unless it is edited or deleted'
: ' if it is approved and published'}
.
{!!changeRequest?.committedAt &&
'You can still edit / remove the change request before this date.'}
</InfoMessage>
</div>
)}

image
image
image

Steps To Reproduce

Create any scheduled change for the future and open it from the Scheduling page.

Expected behavior

Show the go-live date on both the details page, and on each scheduled change in the list page.

Screenshots

No response

@rolodato rolodato added the bug Something isn't working label Jul 30, 2024
@matthewelwell matthewelwell added the front-end Issue related to the React Front End Dashboard label Jul 30, 2024
@matthewelwell
Copy link
Contributor

matthewelwell commented Dec 10, 2024

To avoid, this should actually be resolved in #4852 according to @kyle-ssg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

No branches or pull requests

4 participants