Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State parameter pre-defined options imported incorrectly #65

Closed
tcassell94 opened this issue Jul 2, 2020 · 2 comments
Closed

State parameter pre-defined options imported incorrectly #65

tcassell94 opened this issue Jul 2, 2020 · 2 comments
Labels
resolved on develop Resolved on the development branch, no further work expected.

Comments

@tcassell94
Copy link

If you set some pre-defined options for parameter values (such as in this example state), they are accessed incorrectly in the behavior containing the state.

IE, the state itself would be imported as from flexbe_states_package.state_name import StateName in the behavior_name_sm.py file. But then the state's default parameters are accessed as flexbe_states_package.StateName.DefaultParameterName.

I think the fix is to just access the default parameters as StateName.DefaultParameterName.

@tcassell94
Copy link
Author

It's caused by the value of the default parameter being set in the FlexBE App as package_name.StateName.DefaultParameterName when you click your desired parameter value from the drop-down options. So I guess when you click the drop down the parameter should be set to StateName.DefaultParameterName.

@pschillinger
Copy link
Member

This actually depends on whether the state class name is a duplicate in the workspace or if the respective setting is enabled to consider the state package in addition to the class in general. Still, the completion you pointed out is incorrect in both cases.

The above commit fixes it for both of them.

@pschillinger pschillinger added the resolved on develop Resolved on the development branch, no further work expected. label Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolved on develop Resolved on the development branch, no further work expected.
Projects
None yet
Development

No branches or pull requests

2 participants