-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for react v15.0 #134
Comments
Hi! Since React-Canvas already uses ReactDOM.render to render components, and they use React.createElement/Document.createElement, this is much unlikely. However, you can see that this library hasn't been updated for a while. It uses regular var requires and dependencies hasn't been updated. I'll put up a updated PR later on today, if that helps this issue. 😄 |
The only thing that I can see now that is affected by v15 is |
When i try use react-canvas with react v15, it not working. The react throw exception "Uncaught TypeError: Cannot read property 'props' of undefined" on the function mountComponent of Group component. Any idea for fix this bug? |
I was starting to work on a fix and it's more fundamental than "just fix the assign". there are bunch of problem and I don't have time for this. react-canvas uses bunch of internal React API that have all changed (mountComponent signature, and bunch of other signatures). so I recommend you guys to use react-art that is highly maintain and always up to date. |
Maybe put up a warning at the top of the README... |
I am having the following issue when running an app that is importing 'react-canvas':
I am currently using react v15 and while npm installing I get
Is this a compatibility issue or is something wrong on my end ? I only installed the package and used a very basic Surface + Image. |
It's a compatibility issue. The current implementation is far from working with React 15. |
Oh ok got it! Thanks |
It's possible for someone like me to maybe downgrade to react 0.14 if I knew 15.x support was coming. Is there any information on this anywhere? |
React just release major v15.0 with full svg support.
https://facebook.github.io/react/blog/.
I suppose this could have large impact on react-canvas?
The text was updated successfully, but these errors were encountered: