[Feature Request] Unload web panel on clicking close button

[emvaized]

Is your feature request related to a problem?

When I click close button in the corner of web panel, panel gets closed, but not actually unloaded — when I open it again, it turns out to be running in background and keeps it's state and url. There's entry in panel's context menu to unload it, but it's not handy to use it all the time.

Describe the solution you'd like

Would be great to have an option to unload the panel automatically when user clicks the close button.

And for cases when user actually needs to keep panel running in background (e.g. minimize it), preserve current behavior for click on panel's icon — panel will be minimized, but not unloaded.

Describe alternatives you've considered

Maybe also makes sense to consider adding separate "minimize panel" button, and indicate somehow that panel is minimized (maybe show some little blue dot in the bottom right corner of the icon?)

Additional context

No response

[surapunoyousei]

This is useful when playing music in the background, so I am specifying this. It would just be nice to have the option.

[emvaized]

useful when playing music in the background

I agree. That's why I suggested preserving the current behavior when clicked on the icon itself. But I'm 100% okay with this being an option in settings.

[github-actions[bot]]

This issue is stale because it has been open for 14 days with no activity. Remove stale label or comment to re-open.

[Crunchbits]

I also think that there should be the option to unload web panels by middle clicking their panel icons.

Also I know there's a setting to automatically unload tabs that have not been active in a certain amount of time, but perhaps there should also be a separate automatic unload option specific for web panels.

But yes an indicator on the icons to see if the web panel is loaded is really needed. Or if not, the option to dim unloaded icons.

[emvaized]

I just realized that's exactly how web panels in Microsoft Edge work. They all have both "minimize" and "close" buttons, and when user clicks on the icon itself it minimizes panel instead of closing:

So now we have at least a reference for such behavior implementation from competitors 😅

[black7375]

Floorp already provides such option in icon's context menu – which is essentially the same as "more" button.

Yes. That's right. It perfectly matches my intention.
It is better to make the button group in the context menu easily accessible.
Edge's Minimize, Pinned, and Close arrangements is really confusing.

+.
Closing with the middle button looks good.

[emvaized]

"Pinned" button may be confusing, I'm not even sure what is it. But "Minimize" and "Close" buttons are not confusing, they are very logical and intuitive – it's basically the same as any other window in the system, which has separate "Minimize" and "Close" buttons. I'd argue that current behavior in Floorp is much more confusing ("Close" button actually minimizes the panel, not closes it)

[black7375]

If the unload button is the default close button, there are some problems.

• Should it be unloaded or minimized when the other sidebar button is pressed?
• If you press same sidebar button, most of users will expect to fold(minimize)
  If the close button's action is unload, the action is inconsistent.
• The sidebar button looks like a pinned tab, and people don't want to close the pinned tab.
  I've put so many features in my theme but I've only rolled back the features twice due to my bad decision, and it's one of them.

I have used sidekick, and I think the mental model that treats like pinned tab is more suitable.

[emvaized]

1. I'd say, minimized. When we, as users, switch to another tab or window, we don't expect the previous one to get closed. But we expect the Close button to close them.
2. I agree, that's how it works in Microsoft Edge as well. Clicking on the icon itself should fold the panel rather than close it
3. I don't have any opinion about this, as I don't use pinned tabs. But I treat web panels more like secondary windows, rather than pinned tabs.

[black7375]

It doesn't look bad when I think of sidebar as a taskbar.
But if you think like a tab, it can be a problem. I think there's a trade off in the two choices.

[surapunoyousei]

I'm trying to add this feature, now.

[emvaized]

Awesome, great to hear!

[surapunoyousei]

Added. Wait for Floorp 11.4.0
https://blog.ablaze.one/3520/2023-09-23/

cb90c63

[emvaized]

Thanks, I'll check it!

[surapunoyousei]

If you try these feature more fast, Download beta build.

Unload panel preferences will ship until 24hours

https://github.com/Floorp-Projects/Floorp/releases/tag/beta

[emvaized]

New option works just as intended! But it unfortunately unloads a web panel in both cases ("close" button clicked, or panel's icon itself is clicked). So now, with this new option enabled, there's no way to just minimize the panel without unloading it. Maybe now it makes sense to add a separate "Minimize" button next to "Close" one? Not sure if it's worth creating a new Discussion.

[surapunoyousei]

In fact, I feel that this is an issue of whether it is necessary to go that far since it is optional. It would be subtle since it is not unloaded by default.

[emvaized]

Yes, the separate "Minimize" button would make no sense with the new option disabled — as in this case, both "Minimize" and "Close" buttons will behave the same.

Then, maybe makes sense for the click on the icon itself to behave as "Minimize"?