Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart node missing data after page reconnect #1297

Closed
E1cid opened this issue Sep 16, 2024 · 5 comments · Fixed by #1343
Closed

Chart node missing data after page reconnect #1297

E1cid opened this issue Sep 16, 2024 · 5 comments · Fixed by #1343
Assignees
Labels
bug Something isn't working size:S - 2 Sizing estimation point

Comments

@E1cid
Copy link

E1cid commented Sep 16, 2024

Current Behavior

When you have an open browser tab showing chart in background, after some time the page disconnects. When returning to tab the page reconnect, and does not refresh. When new data comes in the data for the time the page was not connected is missing, It returns after you refresh page.
images available here https://discourse.nodered.org/t/dashboard-2-0-chart-node-page-reconnect-issue/91017

Expected Behavior

When page reconnects the page should be refreshed to show the missing data

Steps To Reproduce

create chart feed in data every 10 seconds. send tab to background. wait 20mins, return to tab and wait for new incoming data

Environment

  • Dashboard version: 1.16
  • Node-RED version: 3.1.3
  • Node.js version: 20
  • npm version: 5
  • Platform/OS: Android
  • Browser: chrome

Have you provided an initial effort estimate for this issue?

I am not a FlowFuse team member

@E1cid E1cid added bug Something isn't working needs-triage Needs looking at to decide what to do labels Sep 16, 2024
@colinl
Copy link
Contributor

colinl commented Sep 16, 2024

Possibly the same issue as #1115, which is the same problem with text widget.

@joepavitt joepavitt moved this from Backlog to Up Next in Dashboard Backlog Sep 18, 2024
@joepavitt joepavitt added size:M - 3 Sizing estimation point and removed needs-triage Needs looking at to decide what to do labels Sep 18, 2024
@colinl
Copy link
Contributor

colinl commented Sep 29, 2024

For the record, this also affects the Switch node. A change of state while disconnected is not shown on re-connection. Probably other node types have the same issue.

@Steve-Mcl
Copy link
Contributor

For the record, this also affects the Switch node. A change of state while disconnected is not shown on re-connection. Probably other node types have the same issue.

My PR #1343 works in such a way that it should be a universal fix (i.e. not only for charts missing data)

@colinl
Copy link
Contributor

colinl commented Sep 29, 2024

I can confirm that the PR does fix the problem, at least for the Text node (#1115) and the Switch node.

@Steve-Mcl
Copy link
Contributor

I can confirm that the PR does fix the problem, at least for the Text node (#1115) and the Switch node.

Thanks for trying it out Colin 👍

@joepavitt joepavitt moved this from Up Next to Done in Dashboard Backlog Oct 4, 2024
@joepavitt joepavitt added size:S - 2 Sizing estimation point and removed size:M - 3 Sizing estimation point labels Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:S - 2 Sizing estimation point
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants