Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose random sampling via api #1007

Closed
greenape opened this issue Jul 1, 2019 · 0 comments · Fixed by #1168
Closed

Expose random sampling via api #1007

greenape opened this issue Jul 1, 2019 · 0 comments · Fixed by #1168
Assignees
Labels
FlowClient Issues related to FlowClient FlowMachine Issues related to FlowMachine

Comments

@greenape
Copy link
Member

greenape commented Jul 1, 2019

I think with random sampling, while this is actually internally a distinct query class, it makes most sense to squash it into the query-to-be-sampled's params in the API, so it is always a modifier on another query.

e.g.

{
        "query_kind": "subscriber_degree",
        ...
        "sampling": {...}
    }

So, a schema that captures Random(..), and then post-load this is converted to the actual Random call.

@greenape greenape added FlowDB Issues related to FlowDB FlowMachine Issues related to FlowMachine FlowClient Issues related to FlowClient and removed FlowDB Issues related to FlowDB labels Jul 1, 2019
@jc-harrison jc-harrison self-assigned this Jul 29, 2019
@mergify mergify bot closed this as completed in #1168 Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FlowClient Issues related to FlowClient FlowMachine Issues related to FlowMachine
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants