Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow unseedable random sample methods through API #1263

Closed
greenape opened this issue Sep 12, 2019 · 1 comment · Fixed by #1273
Closed

Disallow unseedable random sample methods through API #1263

greenape opened this issue Sep 12, 2019 · 1 comment · Fixed by #1273
Labels
FlowAPI Issues related to the FlowKit API FlowMachine Issues related to FlowMachine

Comments

@greenape
Copy link
Member

Only the random sampling methods which can be seeded should be available via the API, because things returned by the API are cached.

And with this, we should change the default random sampling method to a seedable one.

@greenape greenape added FlowMachine Issues related to FlowMachine FlowAPI Issues related to the FlowKit API labels Sep 12, 2019
@jc-harrison
Copy link
Member

Given that random_ids is the only seedable sampling method guaranteed to provide the requested sample size, I would suggest this is a good default. I suspect (but haven't checked) that this is the slowest method, but this is fine as long as the docstring explains the trade-offs and benefits of choosing a non-default sampling method.

@greenape greenape mentioned this issue Sep 16, 2019
8 tasks
@mergify mergify bot closed this as completed in #1273 Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FlowAPI Issues related to the FlowKit API FlowMachine Issues related to FlowMachine
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants