Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlowETL should support docker secrets #1515

Closed
greenape opened this issue Nov 12, 2019 · 0 comments · Fixed by #1517
Closed

FlowETL should support docker secrets #1515

greenape opened this issue Nov 12, 2019 · 0 comments · Fixed by #1517
Labels

Comments

@greenape
Copy link
Member

greenape commented Nov 12, 2019

At the moment, FlowETL (because of the parent image and airflow) will allow you to configure many things using env vars. Obviously we'd rather use secrets in many cases. This should be supported.

Worth considering that this snippet:

shopt -s nullglob
FILES=/run/secrets/*
for f in $FILES; do   
	echo "Loading secret $f."
	export $(basename $f)=$(cat $f)
done

will read all secrets as env vars named for the secret, which might simplify matters.

Alternatively, https://github.com/jezdez/envdir is built for exactly this purpose.

@greenape greenape added enhancement New feature or request security FlowETL labels Nov 12, 2019
@greenape greenape mentioned this issue Nov 12, 2019
8 tasks
@mergify mergify bot closed this as completed in #1517 Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant