Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queries removed from cache can't be re-stored through the API #1898

Closed
jc-harrison opened this issue Feb 3, 2020 · 1 comment · Fixed by #2052
Closed

Queries removed from cache can't be re-stored through the API #1898

jc-harrison opened this issue Feb 3, 2020 · 1 comment · Fixed by #2052
Labels
bug Something isn't working FlowMachine Issues related to FlowMachine

Comments

@jc-harrison
Copy link
Member

Problem
The FlowMachine server only calls store_async on a query object if no query info lookup exists in redis, but if a query has been previously stored and removed from the cache then it will have a query info lookup but will still need to be stored again.

Solution
The server should always call store_async - this is safe even if the query is already running or in cache.

@jc-harrison jc-harrison added bug Something isn't working FlowMachine Issues related to FlowMachine labels Feb 3, 2020
@greenape
Copy link
Member

greenape commented Feb 3, 2020

Safe but slow - preferable would be that the Redis cache either reports the query as unknown once it has been removed from cache, or we use the Redis cache data to only create-and-trigger if necessary.

@greenape greenape mentioned this issue Mar 3, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working FlowMachine Issues related to FlowMachine
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants