Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object-oriented FlowClient? #1980

Closed
jc-harrison opened this issue Feb 19, 2020 · 0 comments · Fixed by #2181
Closed

Object-oriented FlowClient? #1980

jc-harrison opened this issue Feb 19, 2020 · 0 comments · Fixed by #2181
Assignees
Labels
enhancement New feature or request FlowClient Issues related to FlowClient

Comments

@jc-harrison
Copy link
Member

I wonder whether it would be worth implementing a Query class in FlowClient, which contains a query specification along with a run method, and status and result properties. The flowclient functions that currently return a query spec could instead return a fllowclient.Query object.

My feeling is that this might be more intuitive for users, would remove the need for them to deal directly with query IDs, and may help to avoid confusion between query specifications and query results.

@jc-harrison jc-harrison added enhancement New feature or request FlowClient Issues related to FlowClient labels Feb 19, 2020
@greenape greenape mentioned this issue Mar 10, 2020
8 tasks
@mergify mergify bot closed this as completed in #2181 Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request FlowClient Issues related to FlowClient
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant