Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExposedDatetime #4497

Closed
Thingus opened this issue Nov 8, 2021 · 0 comments · Fixed by #4485
Closed

ExposedDatetime #4497

Thingus opened this issue Nov 8, 2021 · 0 comments · Fixed by #4485
Labels
development enhancement New feature or request FlowMachine Issues related to FlowMachine

Comments

@Thingus
Copy link
Contributor

Thingus commented Nov 8, 2021

Is your feature request related to a problem? Please describe.
Datetime is useful for building internal query ranges, but query objects pass datetime around as strings.
Converting between string and datetime internally gets in the way of clean code and can introduce bugs due to malformed date formatting strings

Describe the solution you'd like
Getter and setter mixin for start_date and end_date (for now) that exposes them as datetime objects.

Describe alternatives you've considered
standardise_date can go from most sensible formats to a string, but not to a datetime.

@Thingus Thingus linked a pull request Nov 8, 2021 that will close this issue
8 tasks
@greenape greenape added enhancement New feature or request FlowMachine Issues related to FlowMachine development P-Now labels Nov 8, 2021
@mergify mergify bot closed this as completed in #4485 Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development enhancement New feature or request FlowMachine Issues related to FlowMachine
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants