Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decompose MajorityLocation to improve cache re-use #5720

Closed
jc-harrison opened this issue Dec 23, 2022 · 0 comments · Fixed by #5722
Closed

Decompose MajorityLocation to improve cache re-use #5720

jc-harrison opened this issue Dec 23, 2022 · 0 comments · Fixed by #5722
Labels
FlowMachine Issues related to FlowMachine

Comments

@jc-harrison
Copy link
Member

jc-harrison commented Dec 23, 2022 •
edited
Loading

If a user wants to run a MajorityLocation query excluding unlocatable subscribers, and also the same MajorityLocation query including unlocatable subscribers, these would be two independent queries. But the second case actually requires running the first query, and then joining this to the set of all subscribers with weighted locations. I think it would be beneficial to break down MajorityLocation a little so that a query with include_unlocatable=True uses the corresponding query with include_unlocatable=False as a sub-query, to improve cache re-use in this situation.

Originally posted by @jc-harrison in #5128 (comment)
@jc-harrison jc-harrison added the FlowMachine Issues related to FlowMachine label Dec 23, 2022
@jc-harrison jc-harrison mentioned this issue Dec 23, 2022
Merged
8 tasks
@mergify mergify bot closed this as completed in #5722 Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FlowMachine Issues related to FlowMachine
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changes to MajorityLocation Flowminder/FlowKit
1 participant
@jc-harrison