Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events at midnight should be considered as happening on the following day #575

Closed
maxalbert opened this issue Apr 4, 2019 · 0 comments
Closed

Events at midnight should be considered as happening on the following day #575

maxalbert opened this issue Apr 4, 2019 · 0 comments
Labels
bug Something isn't working FlowMachine Issues related to FlowMachine

Comments

@maxalbert
Copy link
Contributor

Currently the date filtering logic uses <= for comparison with the end date (see here; or here for the old version).

This should be changed to < to avoid potential double-counting and similar issues. Events at midnight should be considered as happening on the following day.
@maxalbert maxalbert added bug Something isn't working FlowMachine Issues related to FlowMachine labels Apr 4, 2019
@maxalbert maxalbert mentioned this issue Apr 4, 2019
Merged
8 tasks
@greenape greenape closed this as completed Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working FlowMachine Issues related to FlowMachine
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@greenape @maxalbert