Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose RadiusOfGyration via api #602

Closed
5 of 7 tasks
greenape opened this issue Apr 9, 2019 · 3 comments · Fixed by #645
Closed
5 of 7 tasks

Expose RadiusOfGyration via api #602

greenape opened this issue Apr 9, 2019 · 3 comments · Fixed by #645
Labels
enhancement New feature or request FlowClient Issues related to FlowClient FlowMachine Issues related to FlowMachine

Comments

@greenape
Copy link
Member

greenape commented Apr 9, 2019

Pending #600

  • Add marshmallow spec for RadiusOfGyration
  • Add to allowable joined aggregate queries
  • Add flowclient function radius_of_gyration(start, stop, subscriber_subset)
  • Add test to integration_tests/tests/test_queries.py
  • Add docs/source/4-developer.md with newly added query
  • Change returned column name to value from rog in RadiusOfGyration in SQL and column_names attribute
  • Update tests using RadiusOfGyration to reflect changed column name
@greenape greenape added enhancement New feature or request FlowClient Issues related to FlowClient FlowMachine Issues related to FlowMachine labels Apr 9, 2019
@OwlHute
Copy link
Contributor

OwlHute commented Apr 17, 2019

Implemented all required code changes, and down to one test error:

Aggregation unit must be specified when running a query.. API returned with status code: 400.{'msg': 'Aggregation unit must be specified when running a query.'}

So it looks like the three parameters given above (start, stop, subscriber_subset) should be augmented by something like aggregation_unit ?!

@greenape
Copy link
Member Author

radius_of_gyration needs to be used in conjunction with joined_spatial_aggregate, because it has no inherent spatial unit attached.

@OwlHute
Copy link
Contributor

OwlHute commented Apr 18, 2019

I'm currently testing a couple of small changes which may fix the remaining errror. So please hold off on review for now. I'll let you know when the changes have been pushed ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request FlowClient Issues related to FlowClient FlowMachine Issues related to FlowMachine
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants