Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMSI/IMEI QA checks should ignore nulls #6619

Closed
jc-harrison opened this issue May 21, 2024 · 0 comments · Fixed by #6621
Closed

IMSI/IMEI QA checks should ignore nulls #6619

jc-harrison opened this issue May 21, 2024 · 0 comments · Fixed by #6621
Labels
bug Something isn't working FlowETL

Comments

@jc-harrison
Copy link
Member

jc-harrison commented May 21, 2024

The FlowETL QA checks count_imsis, count_imeis, max_msisdns_per_imsi and max_msisdns_per_imei count NULL as a valid IMEI/IMSI value. This is particularly problematic for max_msisdns_per_imsi/max_msisdns_per_imei, since these checks will return a very large count if a portion of the events are missing an imei or imsi.

These checks should instead operate only on events with non-null imei/imsi. We have other checks to count the rows where these fields are null.

@jc-harrison jc-harrison added bug Something isn't working FlowETL labels May 21, 2024
@mergify mergify bot closed this as completed in #6621 May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working FlowETL
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant