Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose TopUpAmount via api #967

Closed
9 tasks done
greenape opened this issue Jun 24, 2019 · 0 comments · Fixed by #1030
Closed
9 tasks done

Expose TopUpAmount via api #967

greenape opened this issue Jun 24, 2019 · 0 comments · Fixed by #1030
Assignees
@BhavinPanch
Labels
enhancement New feature or request FlowClient Issues related to FlowClient FlowMachine Issues related to FlowMachine

Comments

@greenape
Copy link
Member

greenape commented Jun 24, 2019 •
edited by BhavinPanch
Loading

  • Add marshmallow spec for TopUpAmount
  • Add to allowable joined aggregate queries
  • Add flowclient function topup_amount(*, start, stop, level, subscriber_subset)
  • Add test to integration_tests/tests/test_queries.py
  • Update acceptance tests
    • integration_tests/tests/flowapi_tests/test_api_spec.py
    • integration_tests/tests/flowmachine_server_tests/test_server.py
  • Update docs/source/4-developer.md with newly added query
  • Update Changelog
@greenape greenape added enhancement New feature or request FlowClient Issues related to FlowClient FlowMachine Issues related to FlowMachine labels Jun 24, 2019
@BhavinPanch BhavinPanch mentioned this issue Jul 3, 2019
Merged
8 tasks
@mergify mergify bot closed this as completed in #1030 Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BhavinPanch BhavinPanch

Labels
enhancement New feature or request FlowClient Issues related to FlowClient FlowMachine Issues related to FlowMachine
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Flowmachine top up amount Flowminder/FlowKit
2 participants
@greenape @BhavinPanch