Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"RangeError: Maximum call stack size exceeded" when using http request node #200

Closed
Torsten85 opened this issue Oct 3, 2020 · 2 comments
Labels

Comments

@Torsten85
Copy link

Describe the bug
Sometimes lights don't react to input from an http request node.

A "RangeError: Maximum call stack size exceeded" error is logged in the server console

Expected behavior
The error should not happen obviously

Please complete the following information:

  • Node-RED version: [latest docker image]
  • Device running Node-RED: [raspberry]

Additional context

the http request node adds msg.req und msg.res to the message object.
Huemagic tries to merge that req object with a future state here: https://github.com/Foddy/node-red-contrib-huemagic/blob/master/huemagic/hue-light.js#L283

The req object has circular fields, so the merge function would call itself indefinitly.
This should be an easy fix.

@Torsten85 Torsten85 added the bug label Oct 3, 2020
Foddy pushed a commit that referenced this issue Oct 11, 2020
* Hue Motion, Hue Brightness, Hue Tap, Hue Switch & Hue Button nodes can now receive a status request
* New "Universal Mode" for the Hue Motion, Hue Brightness, Hue Tap, Hue Switch & Hue Button nodes
* The "colorTemp" property for Hue Light & Hue Group nodes can now also be set to "cold", "normal", "warm" or "auto"
* New dynamic and automatically calculated color temperature based on the current time ("auto" mode in "colorTemp" property)
* Nodes in "Universal Mode" are now also able to receive all events from devices of its type (optional)
* Hue Magic animations are now prerendered to improve performance
* 3 new Hue Magic animations ("Milkyway", "Beach" & "Forest")
* New (simple) Hue Button example flow
* Updated docs for almost all nodes and README
* Fixed an error with future states and the HTTP request node ([#200](#200))
* Other optimizations, dependency updates and clean up
@Foddy
Copy link
Owner

Foddy commented Oct 11, 2020

Should be fixed with the latest version. Let me know if you still face this issue for some reasons...

@Foddy Foddy closed this as completed Oct 11, 2020
@dbowerman
Copy link

I still have this issue with v3.0.0. what can I do to help resolve it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants