foodcritic fails on shorthand cookbook naming

[vinyar]

Functional code:

case node['platform_family']
when 'windows' 
  include_recipe '::windows'
when 'debian', 'rhel' 
  include_recipe '::linux'
end

Results of foodcritic:

$ foodcritic -f correctness .
FC007: Ensure recipe dependencies are reflected in cookbook metadata: ./recipes/default.rb:13
FC007: Ensure recipe dependencies are reflected in cookbook metadata: ./recipes/default.rb:15
FC008: Generated cookbook metadata needs updating: ./metadata.rb:2
FC008: Generated cookbook metadata needs updating: ./metadata.rb:3
FC009: Resource attribute not recognised: ./recipes/linux.rb:55
FC011: Missing README in markdown format: test/README.md:1
FC023: Prefer conditional attributes: ./test/recipes/default_test.rb:8
FC031: Cookbook without metadata file: test/metadata.rb:1
FC045: Metadata does not contain cookbook name: test/metadata.rb:1

Alternatively:

recipe:

case node['platform_family']
when 'windows' 
  include_recipe 'svops_exportc_usermgmt_linux::windows'
when 'debian', 'rhel' 
  include_recipe 'svops_exportc_usermgmt_linux::linux'
end

Foodcritic:

oodcritic -f correctness . -X spec -X test
FC008: Generated cookbook metadata needs updating: ./metadata.rb:2
FC008: Generated cookbook metadata needs updating: ./metadata.rb:3
FC009: Resource attribute not recognised: ./recipes/linux.rb:55

[tas50]

Fixed by #526

[vinyar]

woot!! 👍