Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for electron-node in vscode? #14

Open
c3wenjiaowang opened this issue Apr 3, 2023 · 2 comments
Open

add support for electron-node in vscode? #14

c3wenjiaowang opened this issue Apr 3, 2023 · 2 comments

Comments

@c3wenjiaowang
Copy link

Hi, we are trying to use sync-rpc for an vscode extension, and have some issue with using sync-rpc in electron node in vscode. We have some workaround locally to add support for it to work with vscode. May I ask how can we create a PR for it and try to merge it, as we believe other people working with vscode may have similar issue. Thank you!

@c3wenjiaowang
Copy link
Author

@tonescones FYI.

@tonescones
Copy link

tonescones commented Apr 12, 2023

@ForbesLindesay I think @c3wenjiaowang would like to add a commit to this repo to fix a bug that has been blocking us when using the library within certain electron apps like Vs Code so we were wondering if you could add him as a contributor. If not possible, maybe he could send you the change and you could help us push the commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants