This repository has been archived by the owner on Feb 19, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 51
promise-based rendering. sometimes hangs #103
Labels
Comments
@fleg any ideas what could cause this? error handling maybe? |
ok, it actually returns, but it takes several minutes. The server is in a blocked state during this period. |
figured out the trigger. it's |
This is new in |
Yup. I didn't see it happening before. Might be coincidence of course. I will recheck with older version later today |
I think it's possible #106 would manifest this way for promises. |
Hi guys,
code: export async function getMainComponentStream(MainComponent: any): any {
const componentRenderer = await render(MainComponent);
const templateRenderer = await template`<!doctype html>${componentRenderer}`;
const componentStream = await templateRenderer.toStream();
return componentStream;
} Any ideas? |
@indeyets Is this fixed in |
@ethersage it isn't. still happens here |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I use promise based rendering in a project. Server is build using webpack
Sometimes, while in development mode, I see that rapscallion's promise just never returns. It usually happens when code was just recently build and nodemon started the process. Killing server and starting it manually (without auto-rebuild) usually solves the issue.
I didn't notice this behavior before the update of rapscallion. I see it all the time in my dev-cycle right now (Production env works just fine, but it runs on pre-built code).
UPDATE: figured out the trigger.
NODE_ENV=development
causes the hangThe text was updated successfully, but these errors were encountered: