[Bug] The package for Meteor is outdated at 4.2.0_2

[msamoylov]

It's not possible to upgrade to 4.3.0 from https://atmospherejs.com/fortawesome/fontawesome

[tagliala]

#5062

[dandv]

@splendido is on it!

[splendido]

Ok, I''l try to see what I can do.

@tagliala would you accept a PR which adds only a package.js file to the other PM files already present?

In case you'll feel comfortable with this, the only other changes we'd need would be to make the version field appearing inside the package.js files updated when you make new builds.
In case, could you give some pointer about your building process? I'm not seeing grunt or gulp files...

Tnx,
Luca

Update: it wouldn't be bad to have also a tests.js file specifically for meteor tests to be put where you prefer.

[tagliala]

@splendido
I would like to include official meteor support in 5.0.0 version, but these decisions are up to Dave.

Please send your PR against the 5.0.0-wip branch

In case, could you give some pointer about your building process? I'm not seeing grunt or gulp files...

It's still jekyll based. I mean that jekyll is also responsible of creating .less and .srcc dist files. Very ugly but it does the job. There is a proposal to change the build process ( #1166 ) but this is entirely up to Dave

So: bundle install and jekyll build should be enough: https://github.com/FortAwesome/Font-Awesome#hacking-on-font-awesome

Update: it wouldn't be bad to have also a tests.js file specifically for meteor tests to be put where you prefer.

Put it where you think it is best

[splendido]

Thanks for your availability @tagliala!

Just to confirm: PM files are updated by hands outside of the jekyll build right?
See latest version updates
package.js will be also on the list...

[tagliala]

hmmm not all of them. I don't know if we need to add others to the list (package.js, components.js). I'm doing that manually at the moment

[splendido]

I'd say using gulp to automatize the build process would be the best option.
It's getting more and more reliable and it's actually taking over on grunt!

...to tell you just one example, Jack from SemanticUI is heavily using it (he's refactoring the whole building process right now actually...)

Ideally, all PM files should be automatically generated from the build process picking up the latest package's information from the package.json, so that you won't have to modify them by hands anymore.

But this choice is up to you, surely not up to me. Just my two cents.

Btw, I'll prepare another (leaner) proposal for the meteor integration by means of a PR on the 5.0.0-wip branch.

Tnx!

[tagliala]

But this choice is up to you, surely not up to me. Just my two cents.

I want a better build process, the choice is up to Dave. Don't know his priorities for 5.0.0 :)

[splendido]

Yeah, sorry, with you I meant you package maintainers. Dave is obviously involved ;-)

[splendido]

Done, See #5543!

[serkandurusoy]

Hi there, the package on Meteor is still 4.2.0_2 :(

[splendido]

We're still waiting for #5543 to be merged to get automatic updates...
Before that @dandv can manually update it.

[ErikAbele]

Would be really nice to get this fixed now and for all times… TIA!

[splendido]

@dandv could you make another version bump by hands?

[ErikAbele]

Ping?

[dandv]

Fixed!

[splendido]

now at version 4.4.0: see it on atmoshpere
I guess this issue can be closed now...

[tagliala]

@splendido thanks!

closing here