Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom labels get changed to all lowercase on import #208

Open
7 tasks done
johnnynoone opened this issue Jan 16, 2025 · 3 comments
Open
7 tasks done

Custom labels get changed to all lowercase on import #208

johnnynoone opened this issue Jan 16, 2025 · 3 comments
Labels
bug Something is not working

Comments

@johnnynoone
Copy link

Checklist

  • I can reproduce the bug with the latest version given here.
  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected app version

1.1.0

Affected Android/Custom ROM version

GrapheneOS

Affected device model

Google Pixel 8

How did you install the app?

F-Droid / IzzyOnDroid

Steps to reproduce the bug

  1. Get a vcard that includes a custom label for a phone number. The custom label must have lower and upper case characters, for example Custom Label.
  2. Import the vcard.
  3. Notice that the custom label has become all lowercase, for example custom label.

Expected behavior

The custom label should be preserved verbatim. In the example, it would be Custom Label.

Actual behavior

The custom label is changed to all lowercase, for example custom label.

Screenshots/Screen recordings

No response

Additional information

My use case is exporting all my contacts from one phone and importing them on another phone, both using Fossify Contacts. I have verified that export is correct; the .vcf file contains the custom label as written in the app. Import is buggy as described above.

I have tested this both with my actual contact data and with a specially prepared test vcard. The test vcard is attached for your convenience (zipped to allow GitHub upload). It only contains one contact, with name set to "AAAAName AAAALastname".

test_vcard_AAAA.zip

@johnnynoone johnnynoone added bug Something is not working needs triage Issue is not yet ready for PR authors to take up labels Jan 16, 2025
@johnnynoone
Copy link
Author

@Aga-C Aga-C removed the needs triage Issue is not yet ready for PR authors to take up label Jan 16, 2025
@Aga-C
Copy link
Member

Aga-C commented Jan 16, 2025

We rely for parsing on ez-vcard library and it returns the lowercased type. Probably that's a bug there, or it's done on purpose - in the vCard specification, type is always lowercased.

@johnnynoone
Copy link
Author

For what it's worth, GrapheneOS stock contacts app imports those without lowercasing them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working
Projects
None yet
Development

No branches or pull requests

2 participants