Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unread messages aren't marked as read on opening #264

Open
7 tasks done
astatine opened this issue Dec 27, 2024 · 13 comments
Open
7 tasks done

Unread messages aren't marked as read on opening #264

astatine opened this issue Dec 27, 2024 · 13 comments
Labels
bug Something is not working

Comments

@astatine
Copy link

astatine commented Dec 27, 2024

Checklist

  • I can reproduce the bug with the latest version given here.
  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected app version

1.0.1

Affected Android/Custom ROM version

ArrowOS 13.1 (Android 13 Custom ROM)

Affected device model

Xiaomi Mi A2

How did you install the app?

F-Droid / IzzyOnDroid

Steps to reproduce the bug

Unread messages aren't marked as read on opening, i.e., they are still bold in the message list.

Check the attached screen recording. Sorry about the quality, I wanted to blur stuff out and didn't know what I was doing.

This is not the only 'not-actually-unread' message in my list, there are other messages which are also afflicted by this malaise.

Expected behavior

Unread messages get marked as read on opening.

Actual behavior

Unread messages aren't marked as read on opening

Screenshots/Screen recordings

No response

Additional information

Untitled.Project.mp4
@astatine astatine added bug Something is not working needs triage Issue is not yet ready for PR authors to take up labels Dec 27, 2024
@Aga-C Aga-C removed the needs triage Issue is not yet ready for PR authors to take up label Dec 27, 2024
@naveensingh
Copy link
Member

There is probably at least one message in that thread that was never "read". The app should provide better hints but the messages are marked when they are actually fetched from the database.

Workaround: Try scrolling up for a couple pages and the unread message should get marked as read automatically.

@astatine
Copy link
Author

@naveensingh Thanks for the reply. I scrolled all the way up to the first message in that conversation, and scrolled back down. I did this multiple times. It didn't work.

I then scrolled down my message list and opened a 'not-actually-unread' conversation with only one message. It didn't work here either; going back to the conversation list still showed that conversation in bold.

For now, I've selected all conversations and force-marked them as read to mollify my offended sensibilities. ;-)

@naveensingh
Copy link
Member

I then scrolled down my message list and opened a 'not-actually-unread' conversation with only one message. It didn't work here either; going back to the conversation list still showed that conversation in bold.

must be something else then :)

@astatine
Copy link
Author

@naveensingh @Aga-C It is happening again with v1.1.0 as well. Anything I can do to help you debug?

@naveensingh
Copy link
Member

Thanks but it hasn't been fixed yet. We'll ping you if we need more help.

@astatine
Copy link
Author

Thanks but it hasn't been fixed yet. We'll ping you if we need more help.

So you're able to reproduce it? Just curious. Thanks!

@Aga-C
Copy link
Member

Aga-C commented Dec 31, 2024

@astatine I was able to reproduce it, that's why I've taken off needs triage label. However, I haven't encountered it for the one-message conversation as you described later.

@naveensingh
Copy link
Member

I haven't encountered it for the one-message conversation as you described later.

Same, the workaround works for me.

Would it be better if have something like an overlay with "5 unread messages ↑" or should the app mark everything as read automatically even if the user hasn't scrolled to actually "read" the message?

@tswistak
Copy link

tswistak commented Dec 31, 2024

Would it be better if have something like an overlay with "5 unread messages ↑" or should the app mark everything as read automatically even if the user hasn't scrolled to actually "read" the message?

How about both at once 😄? When I enter the conversation, it shows where are unread messages (they could be marked with some different background too), but leaving the conversation marks all as read.

Actually, even better, it could scroll to the oldest unread message, like e.g. Signal does.

@naveensingh
Copy link
Member

How about both at once 😄? When I enter the conversation, it shows where are unread messages ... but leaving the conversation marks all as read

Yeah, this seems like an acceptable way to implement it without it being 'annoying'.

it could scroll to the oldest unread message

I doubt everyone will like that, we'll let the overlay button with the arrow do the scrolling.

different background

Yep, a slight hint is a good idea. We can fade the unread message from, let's say, 80% opacity to 100%.

@astatine
Copy link
Author

astatine commented Jan 3, 2025

However, I haven't encountered it for the one-message conversation as you described later.

@naveensingh @Aga-C I caught a live one! Hope this helps.

Untitled.Project.mp4

@naveensingh
Copy link
Member

It is all pixelated but I can see it, thanks.

@astatine
Copy link
Author

astatine commented Jan 7, 2025

It is all pixelated but I can see it, thanks.

It is pixelated on purpose for privacy reasons, as before.

I just noticed that a message previously forcefully marked as read is now showing as unread. As before, it does not get marked as read on opening it. Maybe this is related to the other zombie undead unread messages?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working
Projects
None yet
Development

No branches or pull requests

4 participants