Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message with Blocked Keyword Got Through #99

Closed
7 tasks done
Astronox opened this issue Feb 16, 2024 · 7 comments · Fixed by #210
Closed
7 tasks done

Message with Blocked Keyword Got Through #99

Astronox opened this issue Feb 16, 2024 · 7 comments · Fixed by #210
Labels
bug Something is not working

Comments

@Astronox
Copy link

Astronox commented Feb 16, 2024

Checklist

  • I can reproduce the bug with the latest version given here.
  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected app version

1.0.1

Affected Android/Custom ROM version

GrapheneOS Uq1A.240205.004.2024020500

Affected device model

Pixel 8

How did you install the app?

F-Droid / IzzyOnDroid

Steps to reproduce the bug

The text that should have been blocked was a political text. The keyword that should have been blocked was "stop=end". I suspect the message got through because it was sent with an image.

Testing with friends revealed that:
-The original text only contents of the political text were blocked when sent by a friend.
-The SMS character limit is not a factor, the keyword was blocked when at the beginning of a short text and at the end of a long text.

Unfortunately, I forgot to ask them to send the text with an image, so I haven't tested MMS (and I'm a little hesitant to keep bothering my friends with this). Steps to reproduce are most likely:

  1. Set a keyword to block (in this case "stop=end")
  2. Have another party send an MMS with an image and the keyword
  3. MMS should still be delivered with a text that should have been blocked.

Expected behavior

Expected behavior is that any text message, SMS or MMS, image or not, should be blocked if it contains a keyword.
(As a side note, it would be nice to have the option to allow texts that do contain keywords through if they are sent by someone in your contacts).

Actual behavior

A text message with a blocked keyword was received.

Screenshots/Screen recordings

Evidence of blocked message (sent by a friend)
IMG_20240216_163551

Screenshot of message that was blocked (sent by a friend)
IMG_20240216_163703

Screenshot of the original text only version of the message being blocked, "Hello World" was sent after the original text message was sent. I sent them the original contents of the text, they just copied it and sent it back. It was blocked. (sent by a friend)
IMG_20240216_170010

Message failed to block (sent by political organization)
IMG_20240216_170309

Additional information

No response

@Astronox Astronox added bug Something is not working needs triage Issue is not yet ready for PR authors to take up labels Feb 16, 2024
@Aga-C Aga-C removed the needs triage Issue is not yet ready for PR authors to take up label Feb 16, 2024
@Aga-C
Copy link
Member

Aga-C commented Feb 16, 2024

I can confirm that MMS is not blocked.

@CaseOf
Copy link

CaseOf commented Mar 11, 2024

phone numbers blocked are affected by this bug too

@naveensingh
Copy link
Member

@CaseOf are you saying MMS from blocked phone numbers is not blocked?

@CaseOf
Copy link

CaseOf commented Mar 11, 2024

@CaseOf are you saying MMS from blocked phone numbers is not blocked?

on sms, I’m still getting notifications, but when opening the app, the message disappear.

@Astronox
Copy link
Author

I understand this is a feature request, so it should probably get its own post, but would it be possible to allow your contacts to act as a whitelist? That way in case someone I know sends me a blocked keyword I can still see it.

@Aga-C
Copy link
Member

Aga-C commented Mar 12, 2024

I understand this is a feature request, so it should probably get its own post, but would it be possible to allow your contacts to act as a whitelist? That way in case someone I know sends me a blocked keyword I can still see it.

You can create a new feature request for this.

@slhale
Copy link

slhale commented May 21, 2024

I also have been getting this bug. I installed this messages app instead of my phone default because of the keyword blocking, but I constantly still get political messages like this despite them containing keywords that I have blocked. Also, I don't know how to check whether some are getting successfully blocked or not because I don't believe there is any indication in the app if I would have received a message but it was blocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants