Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added possibility to set own sorting for each checklist (#81) #82

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Aga-C
Copy link
Member

@Aga-C Aga-C commented Nov 30, 2024

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

Description of the changes in your PR

  • Added possibility to set own sorting for each checklist.
    • Reused customSorting logic from Commons.
    • Because it's called customSorting in other apps, and "custom sorting" means something different here, I've created helpers with the name ownSorting.
    • Sorting is applied both inside the app and for widgets.
  • Refactored moveDoneChecklistItems to be part of config.sorting, so it's also possible to set it separately for each checklist.
    • Added it as another flag to config.sorting, similarly as showing items count has been done in Gallery's grouping options.
    • To not lose users settings, I've created a migration, that is run only once. It copies the moveDoneChecklistItems value to be a flag in a current config.sorting.
  • Additionally, it fixes two bugs:

Before/After Screenshots/Screen Record

qemu-system-x86_64_1GqMvlYkTT.mp4

Fixes the following issue(s)

Acknowledgement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement of the overview screen Sort by feature for each Note
1 participant