Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OEM error handling from config #592

Open
rumpelsepp opened this issue Sep 19, 2024 · 1 comment
Open

OEM error handling from config #592

rumpelsepp opened this issue Sep 19, 2024 · 1 comment

Comments

@rumpelsepp
Copy link
Member

If an invalid OEM in the config is set, than no error is logged.

/cc @peckto @VeroSec

@rumpelsepp rumpelsepp added the bug Something isn't working label Sep 19, 2024
@rumpelsepp
Copy link
Member Author

@peckto @VeroSec Do you have a reproducer for this? I am not sure how this bug is triggered:

def load_ecu(vendor: str) -> type[ECU]:
"""Selects an ecu class depending on a vendor string.
The lookup is performed in builtin ecus and all
classes behind the ``gallia_uds_ecus`` entry_point.
The vendor string ``default`` selects a generic ECU.
"""
if vendor == "default":
return ECU
for ecu in load_ecu_plugins():
if vendor == ecu.OEM:
return ecu
raise ValueError(f"no such OEM: '{vendor}'")

@rumpelsepp rumpelsepp removed the bug Something isn't working label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant